feat: real pre-recording Scene Inspector panel - #25
Merged
Conversation
The Studio window's "Scene Inspector" sidebar showed four disabled, hardcoded rows (Format: 16:9 Desktop, Canvas Style: Clean Demo, Pointer: Soft Highlight, Captions: Smart Draft) with no state or handlers behind them at all. Replaces them with real, working controls wired to the same persisted editor preferences the post-recording editor already reads on load: - Format -> default aspect ratio for new recordings - Wallpaper -> default background for new recordings - Pointer -> default cursor style for new recordings - Caption Language -> default transcription language (used once captions are generated in the editor; doesn't auto-trigger generation, since that requires an already-downloaded Whisper model and is a deliberately opt-in, user-initiated action elsewhere in the app) Adds a new autoCaptionLanguage field to EditorPreferences (persisted via the same getAppSetting/setAppSetting bridge already used for every other preference here), defaulting to "auto". Verified live: changed a setting in the Studio panel, confirmed it persisted via getAppSetting, then opened a fresh editor window and confirmed both the persisted value and the actual React state/UI (cursor style selector) picked it up correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EditorPreferencesthe post-recording editor already reads on load.autoCaptionLanguagetoEditorPreferences(new field, defaults to"auto").Test plan
npx tsc -p tsconfig.json --noEmit— cleannpx vitest --run— 819/819 passinggetAppSettingthat it persisted