feat: enable click-highlight cursor effect by default; keep webcam/CUDA opt-in - #26
Merged
Merged
Conversation
Reviewed the fully-built-but-off-by-default features: - Cursor click-highlight effect (spotlight/ripple/echo) -> now ON by default (ripple). It's pure visual polish with no permission requirements, no external dependencies, and no failure mode - the accompanying color/scale/opacity/duration defaults were already meaningful non-zero values, so the feature was fully baked and just never reachable via defaults. Ripple picked as the least visually loud of the three styles (a single expanding ring vs. spotlight's glow or echo's double ring). - Webcam overlay (`webcam.enabled`) -> left OFF. The auto-link logic in VideoEditor.tsx already forces `enabled: Boolean(sessionWebcamPath)` whenever a companion webcam recording is found, so the base default is already irrelevant for the common case; flipping it wouldn't change real behavior and risks showing a stale bubble if a `sourcePath` ever carries over without a corresponding video. - NVIDIA CUDA export acceleration -> left OFF. Explicitly named "experimental" in the codebase by whoever built it, and there's no NVIDIA hardware available in this environment to validate it's safe to force on. Respecting that judgment call rather than overriding it without the ability to test it. - Auto-captions -> left OFF (already covered in an earlier item's reasoning): needs an explicit, large Whisper model download the user hasn't asked for. Verified live against a packaged build: cleared the persisted cursorClickEffect preference (this machine already had "none" saved from before this change, which correctly took precedence over the new code default - persisted preferences are expected to outrank in-code defaults), reloaded, and confirmed "Ripple" now shows as the active selection with its Effect Color/Size/Opacity/Duration sub-controls visible and matching the existing default values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reviewed the features that are fully built but shipped off by default, and decided which to flip on:
ripple)VideoEditor.tsx's auto-link logic already forcesenabled: Boolean(sessionWebcamPath)whenever a companion webcam recording exists, so the base default doesn't affect the common case. Flipping it risks showing a stale bubble ifsourcePathever carries over without a matching video.Net change: a single default constant flip (
DEFAULT_CURSOR_CLICK_EFFECT), plus the reasoning above for the record.Test plan
npx tsc -p tsconfig.json --noEmit— cleannpx vitest --run— 819/819 passing