-
Notifications
You must be signed in to change notification settings - Fork 486
[WIP] Delete unused files #14973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
[WIP] Delete unused files #14973
Conversation
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
|
Error while checking build/O2/fullCI_slc9 for 748fad9 at 2026-01-20 11:50: Full log here. |
| * | ||
| * FOCAL reconstruction workflow package. See \ref refFOCALworkflow | ||
| * for more information. | ||
| */ No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the FOCAL part in O2 is under construction, I suggest to not remove anything please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recovered
|
Hi @vkucera, Some of the MID code proposed to be suppressed in this PR has been used for analyses on some tests bench. If there is no necessity to remove the code, I would prefer that we keep it. @dstocco can you confirm what needs to be kept for MID? I am also checking for the MCH files with @aferrero2707 @pillot and other muon experts, please do not go ahead with removing code before our feedbacks. Thanks, |
|
In the past we were indeed using the MID decoded-data-dump-workflow. However, looking now at this PR, I realise that the code is not in a CMakeLists.txt, so indeed it does not seem to be compiled. |
|
@vkucera please remove the changes to any ITS2&3 code. In the former case, I will open a PR soon where this is anyways done, in the latter its plainly wrong that the digit reader/writer is not built, will fix soon. |
Recovered |
There are quite a few files which appear to be unused (i.e. neither included nor compiled).
Please check whether any of them are used outside the repository or should be kept for other reasons.