ASoA: Fix includes#15588
Conversation
|
The "fix" is wrong. As usual one should not blindly run IWYU, but do a proper review of the headers. For example, StringHelpers.h should probably export string and string_view. |
|
Also, I am not sure this is actually the highest priority we have, if at all. |
What exactly is wrong? |
The header does not compile which prevents other headers that include it from compiling too. I would say it's quite important. |
|
Log, please. |
|
"wrong" as in "pollutes ASoA.h with unneeded include statements which should be considered exported by other headers. See the StringHelpers.h example". |
OK. How about just adding |
TBufferFile.his needed byDECLARE_SOA_CCDB_COLUMN_FULL.That's why
Common/DataModel/GloCCDBObjects.hin O2Physics currently cannot be compiled.