feat: make wandb an optional dependency#144
Open
anthony-maio wants to merge 1 commit intoAlignmentResearch:mainfrom
Open
feat: make wandb an optional dependency#144anthony-maio wants to merge 1 commit intoAlignmentResearch:mainfrom
anthony-maio wants to merge 1 commit intoAlignmentResearch:mainfrom
Conversation
Move wandb from core dependencies to a `training` optional extra. Inference-only users no longer need wandb installed. The three import sites in train_loop.py now raise a clear error message pointing to `pip install tuned-lens[training]` when wandb is missing.
Author
|
@codex review |
There was a problem hiding this comment.
Pull request overview
This PR makes wandb an optional dependency by moving it from core dependencies to a training optional extra in pyproject.toml. The change enables inference-only users to install the package without wandb, reducing unnecessary dependencies.
Changes:
- Moved
wandb>=0.15.0from core dependencies to a newtrainingoptional extra in pyproject.toml - Protected all three wandb import sites in train_loop.py with try-except blocks that raise clear ImportError messages
- Error messages guide users to install with
pip install tuned-lens[training]when wandb is needed but missing
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyproject.toml | Removed wandb from core dependencies and added it to a new training optional extra |
| tuned_lens/scripts/train_loop.py | Added try-except blocks around wandb imports in _get_wandb_id, _init_logging, and _log methods with clear error messages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move wandb from core dependencies to a
trainingoptional extra. Inference-only users no longer need wandb installed. The three import sites in train_loop.py now raise a clear error message pointing topip install tuned-lens[training]when wandb is missing.