Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR focuses on UI improvements for different orientations and upgrades the Android SDK version. The changes enhance the user interface by creating orientation-specific layouts and styles, while also updating dependencies and build configurations to use more recent versions.
- Adds orientation-specific styles and layouts to improve UI responsiveness across portrait and landscape modes
- Upgrades Android SDK from version 34 to 36 and updates various dependencies including Gradle wrapper
- Implements edge-to-edge display support and updates CI/CD workflow actions
Reviewed Changes
Copilot reviewed 17 out of 28 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| gradle/wrapper/gradle-wrapper.properties | Updates Gradle version from 8.7 to 8.13 |
| app/src/main/res/values/styles.xml | Adds portrait-specific styles for better UI scaling |
| app/src/main/res/values/dimens.xml | Adds new dimension values for portrait layouts |
| app/src/main/res/layout/layout_numbers_person.xml | Updates to use portrait-specific styles |
| app/src/main/res/layout/layout_numbers_pc.xml | Updates to use portrait-specific styles |
| app/src/main/res/layout/layout_letters_person.xml | Updates to use portrait-specific styles |
| app/src/main/res/layout/layout_letters_pc.xml | Updates to use portrait-specific styles |
| app/src/main/res/layout/activity_main.xml | Adjusts layout positioning and applies portrait styles |
| app/src/main/res/layout-land/layout_numbers_person.xml | Creates landscape-specific layout for numbers |
| app/src/main/res/layout-land/layout_numbers_pc.xml | Creates landscape-specific layout for PC numbers |
| app/src/main/res/layout-land/layout_letters_person.xml | Creates landscape-specific layout for letters |
| app/src/main/res/layout-land/layout_letters_pc.xml | Creates landscape-specific layout for PC letters |
| app/src/main/res/drawable/ic_more.xml | Increases icon size from 24dp to 30dp |
| app/src/main/java/com/avs/sea/battle/main/MainActivity.kt | Implements edge-to-edge display support |
| app/build.gradle | Updates SDK versions and dependency versions |
| README.md | Updates download count from 10K+ to 50K+ |
| .github/workflows/android_build.yml | Updates GitHub Actions to newer versions |
Files not reviewed (9)
- .idea/AndroidProjectSystem.xml: Language not supported
- .idea/codeStyles/Project.xml: Language not supported
- .idea/compiler.xml: Language not supported
- .idea/deploymentTargetSelector.xml: Language not supported
- .idea/gradle.xml: Language not supported
- .idea/kotlinc.xml: Language not supported
- .idea/misc.xml: Language not supported
- .idea/other.xml: Language not supported
- .idea/runConfigurations.xml: Language not supported
Comments suppressed due to low confidence (1)
app/src/main/res/values/styles.xml:34
- The parent style should be "SingleCharacterStyle" instead of "SingleDigitStyle" to maintain proper inheritance hierarchy, as this style is for characters, not digits.
<style name="SingleCharacterStylePortrait" parent="SingleDigitStyle">
| binding.mainViewModel = viewModel | ||
|
|
||
| ViewCompat.setOnApplyWindowInsetsListener(binding.root) { view, windowInsets -> | ||
| val insets = windowInsets.getInsets(WindowInsetsCompat.Type.systemGestures()) |
There was a problem hiding this comment.
Using WindowInsetsCompat.Type.systemGestures() is incorrect for padding adjustments. This should be WindowInsetsCompat.Type.systemBars() to handle status bar and navigation bar insets properly.
Suggested change
| val insets = windowInsets.getInsets(WindowInsetsCompat.Type.systemGestures()) | |
| val insets = windowInsets.getInsets(WindowInsetsCompat.Type.systemBars()) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.