Fix DEPENDENCIES.md CI/CD workflow description#10
Fix DEPENDENCIES.md CI/CD workflow description#10perNyfelt merged 2 commits intosecurity_dependenciesfrom
Conversation
Co-authored-by: perNyfelt <13261538+perNyfelt@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the docs/DEPENDENCIES.md file to correct the CI/CD workflow description. The previous documentation incorrectly stated that dependency checks run on each push. The update aims to clarify that the dependency-check job has conditions for schedule or workflow_dispatch events.
Key Changes:
- Replaced generic step-level examples with the actual job structure from
ci.yml - Updated description to reflect conditional execution based on event types
- Added rationale explaining the scheduled approach keeps regular CI builds fast
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ## CI/CD Integration | ||
|
|
||
| The GitHub Actions workflow runs dependency checks on each push: | ||
| The GitHub Actions workflow includes a separate `dependency-check` job that runs on a schedule or manual workflow dispatch: |
There was a problem hiding this comment.
The documentation states that the dependency-check job runs "on a schedule or manual workflow dispatch", but the actual ci.yml workflow file does not include schedule or workflow_dispatch in its trigger section (the on: section only includes push and pull_request). This means the dependency-check job will never execute, even though it has a condition checking for these events. Either the ci.yml workflow needs to be updated to include these triggers, or this documentation should accurately describe that the job is currently defined but not triggered.
The documentation incorrectly stated that dependency checks run on each push, but the actual workflow only runs them on schedule or manual dispatch.
Changes:
docs/DEPENDENCIES.mdto accurately reflect that thedependency-checkjob runs onscheduleorworkflow_dispatchevents, not on pushci.ymlBefore:
After:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.