Skip to content

Fix GPG secret naming inconsistency in publishing documentation#12

Merged
perNyfelt merged 2 commits intosecurity_dependenciesfrom
copilot/sub-pr-8-yet-again
Dec 16, 2025
Merged

Fix GPG secret naming inconsistency in publishing documentation#12
perNyfelt merged 2 commits intosecurity_dependenciesfrom
copilot/sub-pr-8-yet-again

Conversation

Copy link
Contributor

Copilot AI commented Dec 16, 2025

The CI/CD setup section referenced secrets.GPG_KEY_ID in the workflow example but didn't list it as a required secret.

Changes:

  • Added GPG_KEY_ID to the list of required GitHub repository secrets with example format

The documentation now correctly lists all five secrets used in the workflow:

env:
  ORG_GRADLE_PROJECT_signingKeyId: ${{ secrets.GPG_KEY_ID }}  # Now documented
  ORG_GRADLE_PROJECT_signingKey: ${{ secrets.GPG_SIGNING_KEY }}
  ORG_GRADLE_PROJECT_signingPassword: ${{ secrets.GPG_SIGNING_PASSWORD }}

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: perNyfelt <13261538+perNyfelt@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on security and dependencies pull request Fix GPG secret naming inconsistency in publishing documentation Dec 16, 2025
Copilot AI requested a review from perNyfelt December 16, 2025 23:01
@perNyfelt perNyfelt marked this pull request as ready for review December 16, 2025 23:04
Copilot AI review requested due to automatic review settings December 16, 2025 23:04
@perNyfelt perNyfelt merged commit b08b7fa into security_dependencies Dec 16, 2025
@perNyfelt perNyfelt deleted the copilot/sub-pr-8-yet-again branch December 16, 2025 23:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a documentation inconsistency in the publishing guide where the workflow example referenced secrets.GPG_KEY_ID (line 188) but this secret was not listed in the required secrets section above.

Key Changes:

  • Added GPG_KEY_ID to the list of required GitHub repository secrets in the CI/CD Setup section
  • Included format example "(the key ID, e.g., ABCD1234)" consistent with the documentation style for other secrets

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants