Open
Conversation
ryan-berger
force-pushed
the
angle-divisions
branch
from
b97d90b to
9f7fbf9
Compare
ryan-berger
changed the title
tombh
requested changes
Feb 11, 2026
ryan-berger
force-pushed
the
angle-divisions
branch
from
9f7fbf9 to
165f4a5
Compare
We currently only calculate 360 different lines of sight with our azimuthal projection. This can potentially lead to a lack of coverage, especially in very long lines of sight. This adds a command line option --angle-subdivisions which allows for a user-configured angle subdivision to get coverage up to .01 of a degree
ryan-berger
force-pushed
the
angle-divisions
branch
from
165f4a5 to
bc2e5fb
Compare
Collaborator
|
Another thing I thought, is there a simple smoke test for this? Like how much do the TVS and Longest Line unit tests change with more angles? And did you try making a heatmap PNG? We also need to update the viewshed code to be able to create viewsheds from increased angles. We can just make an issue for that. |
Collaborator
|
Just thought of something else: we're losing fidelity because the angle is stored as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently only calculate 360 different lines of sight with our azimuthal projection. This can potentially lead to a lack of coverage, especially in very long lines of sight. This adds a command line option --angle-subdivisions which allows for a user-configured angle subdivision to get coverage up to .01 of a degree