Conversation
✅ Deploy Preview for cell-catalog ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #423 by unifying inconsistent field names for hPSCreg certificate data across the codebase. Previously, the same data was referenced using two different field names: eu_hpsc_reg in markdown files and GraphQL queries, and hPSCreg_certificate_link in the config file. This inconsistency caused data fetching issues.
Changes:
- Unified all field references to use the consistent lowercase naming convention:
hpscreg_certificate_link - Updated configuration files, TypeScript type definitions, GraphQL queries, data converters, and all 64+ markdown data files
- Maintains backward compatibility by only changing internal field references
Reviewed changes
Copilot reviewed 66 out of 66 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| static/admin/config.yml | Changed field name from hPSCreg_certificate_link to hpscreg_certificate_link in admin config (2 locations) |
| src/templates/cell-line.tsx | Updated GraphQL query to use hpscreg_certificate_link instead of eu_hpsc_reg |
| src/component-queries/types.ts | Updated type definitions for both NormalCellLineFrontmatter and DiseaseCellLineFrontmatter interfaces |
| src/components/SubPage/convert-data.ts | Updated data converters to reference hpscreg_certificate_link in both normal and disease cell line unpacking functions |
| src/component-queries/convert-data.ts | Updated converter functions to use the unified field name |
| 64 cell line markdown files | Changed field name from eu_hpsc_reg or hPSCreg_certificate_link to hpscreg_certificate_link consistently |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
interim17
approved these changes
Feb 17, 2026
meganrm
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
What is the problem this work solves, including
closes #423
Solution
unified the hPSCreg certificate field name across the codebase to avoid data not fetched issue
eu_hpsc_regtohpscreg_certificate_linkin markdown files, graphql queries, data converters and typeshPSCreg_certificate_linkto lowercasehpscreg_certificate_linkin configType of change
Please delete options that are not relevant.
Steps to Verify: