Quickly get sweep numbers without generating sweep table#463
Open
kasbaker wants to merge 4 commits intoAllenInstitute:masterfrom
Open
Quickly get sweep numbers without generating sweep table#463kasbaker wants to merge 4 commits intoAllenInstitute:masterfrom
kasbaker wants to merge 4 commits intoAllenInstitute:masterfrom
Conversation
…mbers without generating sweep_table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview:
Generating the sweep table can take a long time. For fast plotting, all you need is
sweep_datafor each sweep you want to plot. AddingEphysDataSet.sweep_numbersas a property that returnsEPhysDataSet._data.sweep_numbersallows you tomapEPhysDataSet.get_sweep_dataonto thesweep_numbersyou wish to plot.Addresses:
This is a small addition so no issue was created on GitHub
Type of Fix:
functionality to not work as expected)
Solution:
Adding
sweep_numbersas a property avoids accessing._data, a protected attribute of this class.Changes:
Just these lines added to
ephys_data_set.pyValidation:
Tested in a scratch file:
Prints an array of sweep numbers as expected
Screenshots: N/A
Unit Tests: N/A
Script to reproduce error and fix: N/A
Configuration details: N/A
Checklist
Allen Institute Contribution Guidelines
Numpy Standards
appropriate
Notes:
N/A