feat: get_record_by_name and get_projection_by_name helpers#211
feat: get_record_by_name and get_projection_by_name helpers#211helen-m-lin merged 1 commit intodevfrom
Conversation
jtyoung84
left a comment
There was a problem hiding this comment.
Can these be made class methods on the client instead of adding them to the helpers class? Also, it seems like they can be combined into one function by making the projection an optional dict with default None.
|
I followed the format of the existing |
|
I like the idea of combining with an optional arg, and don't expect breaking changes will be a big issue here. @jtyoung84 are you suggesting moving everything in this helpers.docdb module to client class methods? I don't have a strong preference either way but it would be a bit odd to move some and not all. |
|
I guess one reason not to would be if we were open to eventually adding the option of returning validated Pydantic objects as I suggested in the issue - then I assume we'd want to keep the aind-data-schema dependency isolated to the helpers module. |
jtyoung84
left a comment
There was a problem hiding this comment.
I reckon we can leave this as is. We can refactor things in the next major release.
* feat: get_record_by_name and get_projection_by_name helpers (#211) * ci: bump version to 1.10.0
closes #210
This PR adds
get_record_by_nameandget_projection_by_namehelper methods following the format of the existing "get by id" helpers.