Skip to content

Only use valid registers during test #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bruno-f-cruz merged 2 commits into from
May 5, 2026
Merged

Only use valid registers during test #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2381fa8
Only use valid registers during test
bruno-f-cruz May 5, 2026
0ac8a84
Mock the fail test
bruno-f-cruz May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions src/contraqctor/qc/harp/harp_device.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,15 +112,7 @@ def test_read_dump_is_complete(self):
"""
Check if the read dump from an harp device is complete
"""
expected_regs = self.harp_device.device_reader.device.registers.keys()
ds = [stream for stream in self.harp_device]
missing_regs = [reg_name for reg_name in expected_regs if reg_name not in [r.name for r in ds]]
if len(missing_regs) > 0:
return self.fail_test(
False,
"Read dump is not complete. Some registers are missing.",
context={"missing_registers": missing_regs},
)

def _try_get_last_read(r: HarpRegister) -> t.Optional[pd.DataFrame]:
"""We will assume that all data is loaded. If not we will return None
Expand All @@ -130,9 +122,8 @@ def _try_get_last_read(r: HarpRegister) -> t.Optional[pd.DataFrame]:
except ValueError:
return None

missing_read_dump = [
r.name for r in ds if not (r.name in expected_regs and (_try_get_last_read(r) is not None))
]
missing_read_dump = [r.name for r in ds if not (_try_get_last_read(r) is not None)]

return (
self.pass_test(True, "Read dump is complete")
if len(missing_read_dump) == 0
Expand Down
6 changes: 5 additions & 1 deletion tests/test_qc/harp/test_harp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,11 @@ def test_read_dump_is_complete(self, mock_harp_device):
result = suite.test_read_dump_is_complete()
assert result.status == Status.PASSED

suite.harp_device.device_reader.device.registers["MissingReg"] = {}
no_read_df = pd.DataFrame(
{"NoReadReg": [1], "MessageType": ["WRITE"]},
index=pd.Index([1.0], name="Seconds"),
)
suite.harp_device._registers["NoReadReg"] = MockHarpRegister("NoReadReg", no_read_df)
result = suite.test_read_dump_is_complete()
assert result.status == Status.FAILED
assert "missing_registers" in result.context
Expand Down
Loading