Skip to content

Replace SLIMS calls with subprocess call to waterlog app#1742

Open
patricklatimer wants to merge 2 commits into
AllenNeuralDynamics:developfrom
patricklatimer:replace-slims-with-waterlog-adapter
Open

Replace SLIMS calls with subprocess call to waterlog app#1742
patricklatimer wants to merge 2 commits into
AllenNeuralDynamics:developfrom
patricklatimer:replace-slims-with-waterlog-adapter

Conversation

@patricklatimer
Copy link
Copy Markdown
Contributor

Describe changes:

Replaces SLIMS waterlog post with subprocess call to waterlog app running on the computer. Waterlog will be automatically opened if it isn't already running, and will be filled with the experimenter's name, mouse_id, weight, and earned_water.

What issues or discussions does this update address?

#1717

Describe the expected change in behavior from the perspective of the experimenter

Experimenters will have to move over to waterlog and hit submit. (and potentially deliver water)

Describe any manual update steps for task computers

Requires being deployed alongside waterlog >4.1.0

Was this update tested in 446/447?

Not yet

Does this update impact downstream processing by adding new saved files, or changing their format? If so, have you documented changes?

No, but waterlog database information (currently SLIMS, soon dataverse) will look slightly different.

@patricklatimer
Copy link
Copy Markdown
Contributor Author

I added the waterlog CLI subprocess call, but there's a few TODOs called out in comments to address.

  1. Should we validate the experimenter name? IDK if this is already happening, or maybe it should happen elsewhere in the DF GUI. We can validate against the active directory by hitting the new metadata-service endpoint
  2. Should we remove the suggested water calculation from DF? Waterlog is capable of this and it'd probably be simpler to remove it from DF. I'm not familiar enough with how the UI works to remove it though. This'll work for now, users will just have to hit "submit" on waterlog.
  3. We may want to add waterlog functionality to let the database know records are coming from DF.
  4. We may want to add a popup message to the user to remind them to go over to waterlog and hit Submit.

@micahwoodard I don't have permissions to assign you as a reviewer or assignee so a tag will have to do.

@alexpiet alexpiet requested a review from micahwoodard May 7, 2026 20:19
Comment thread src/foraging_gui/Foraging.py Outdated
Comment thread src/foraging_gui/Foraging.py Outdated
Comment thread src/foraging_gui/Foraging.py Outdated
Comment thread src/foraging_gui/Foraging.py
Copy link
Copy Markdown
Collaborator

@micahwoodard micahwoodard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, some things just need to be clarified/finished up

@patricklatimer patricklatimer marked this pull request as ready for review May 11, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants