Replace SLIMS calls with subprocess call to waterlog app#1742
Open
patricklatimer wants to merge 2 commits into
Open
Replace SLIMS calls with subprocess call to waterlog app#1742patricklatimer wants to merge 2 commits into
patricklatimer wants to merge 2 commits into
Conversation
Contributor
Author
|
I added the waterlog CLI subprocess call, but there's a few TODOs called out in comments to address.
@micahwoodard I don't have permissions to assign you as a reviewer or assignee so a tag will have to do. |
micahwoodard
requested changes
May 11, 2026
Collaborator
micahwoodard
left a comment
There was a problem hiding this comment.
Looks good to me, some things just need to be clarified/finished up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe changes:
Replaces SLIMS waterlog post with subprocess call to waterlog app running on the computer. Waterlog will be automatically opened if it isn't already running, and will be filled with the experimenter's name, mouse_id, weight, and earned_water.
What issues or discussions does this update address?
#1717
Describe the expected change in behavior from the perspective of the experimenter
Experimenters will have to move over to waterlog and hit submit. (and potentially deliver water)
Describe any manual update steps for task computers
Requires being deployed alongside waterlog >4.1.0
Was this update tested in 446/447?
Not yet
Does this update impact downstream processing by adding new saved files, or changing their format? If so, have you documented changes?
No, but waterlog database information (currently SLIMS, soon dataverse) will look slightly different.