fix: recycle particle instead of emitter position back to pool in ParticleSystem#1470
Open
evanofficial wants to merge 1 commit intoAlmasB:devfrom
Open
fix: recycle particle instead of emitter position back to pool in ParticleSystem#1470evanofficial wants to merge 1 commit intoAlmasB:devfrom
evanofficial wants to merge 1 commit intoAlmasB:devfrom
Conversation
…ticleSystem Pools.free(p) was incorrectly freeing the emitter's Point2D position instead of the expired particle, causing wrong objects to be recycled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1417
In
ParticleSystem.onUpdate, when a particle expires it should be returned to the object pool viaPools.free(particle). Instead,Pools.free(p)was being called, which freed the emitter'sPoint2Dposition — a completely different object.Changed
Pools.free(p)→Pools.free(particle)on the removal path.