feat: add Street Fighter, Terraria, and Space Invaders datasets#23
Open
tashapais wants to merge 1 commit into
Open
feat: add Street Fighter, Terraria, and Space Invaders datasets#23tashapais wants to merge 1 commit into
tashapais wants to merge 1 commit into
Conversation
Adds StreetFighterDataset, TerrariaDataset, and SpaceInvadersDataset subclasses of VideoHDF5Dataset with appropriate resolution and fps defaults. Also adds corresponding loader functions and dispatch cases in data_utils.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StreetFighterDataset,TerrariaDataset, andSpaceInvadersDatasetsubclasses indatasets/datasets.py, following the same pattern as existing dataset classesload_street_fighter,load_terraria, andload_space_invadersloader functions indatasets/data_utils.pySTREET_FIGHTER,TERRARIA, andSPACE_INVADERSdispatch cases inload_data_and_data_loadersEach new dataset uses sensible defaults:
To use, place your mp4 at the corresponding
/data/path (e.g.street_fighter.mp4) and pass the dataset name string to the config.Test plan
/data/street_fighter.mp4and runpython scripts/full_train.py --config configs/training.yaml -- dataset=STREET_FIGHTERterraria.mp4/TERRARIAandspace_invaders.mp4/SPACE_INVADERS