fix: address Sentry review findings from PR #144#147
Merged
anandgupta42 merged 1 commit intomainfrom Mar 15, 2026
Merged
Conversation
- Use unique `MessageID`/`SessionID` instead of hardcoded `"enhance-prompt"` string for synthetic LLM calls (prevents future API validation breakage) - Add `enhancingInProgress` guard to manual enhance handler to prevent concurrent enhancement race with auto-enhance on submit - Fix auto-enhance early `return` that orphaned sessions: now uses latest user text and continues submission instead of silently abandoning it Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
anandgupta42
added a commit
that referenced
this pull request
Mar 17, 2026
- Use unique `MessageID`/`SessionID` instead of hardcoded `"enhance-prompt"` string for synthetic LLM calls (prevents future API validation breakage) - Add `enhancingInProgress` guard to manual enhance handler to prevent concurrent enhancement race with auto-enhance on submit - Fix auto-enhance early `return` that orphaned sessions: now uses latest user text and continues submission instead of silently abandoning it Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes 3 valid Sentry bot findings from PR #144 (AI-powered prompt enhancement):
MessageID.ascending()/SessionID.descending()instead of hardcoded"enhance-prompt"string for synthetic LLM callsenhancingInProgressflag +finallycleanup to manual enhance handler, preventing race with auto-enhance on submit3 other Sentry findings were false positives (stream already consumed at L139-141, compaction circuit breaker already exists in
compaction.ts).Type of change
Issue for this PR
Closes #17639
How did you verify your code works?
bun test test/altimate/enhance-prompt.test.ts)turbo typecheck)Checklist
🤖 Generated with Claude Code