fix: gate release workflow on tests and add build branding guards#157
Merged
anandgupta42 merged 4 commits intomainfrom Mar 15, 2026
Merged
fix: gate release workflow on tests and add build branding guards#157anandgupta42 merged 4 commits intomainfrom
anandgupta42 merged 4 commits intomainfrom
Conversation
Release workflow: - Add test job (typecheck + bun test) that must pass before build/publish - Both build and publish-engine now depend on test job Branding guard tests (upstream-merge-guard.test.ts): - build.ts binary name is 'altimate' not 'opencode' - build.ts user-agent is 'altimate/' not 'opencode/' - build.ts embeds ALTIMATE_ENGINE_VERSION - build.ts reads engine version from pyproject.toml - build.ts creates altimate-code backward-compat symlink - build.ts has sourcemap: "external" - package.json bin entries are correct (no 'opencode') - package.json has no junk fields or echo-stub scripts - bin/opencode does not exist - keepOurs config includes build.ts, publish.ts, bin/**, CHANGELOG.md Publish package test: - Assert 'altimate' bin points to ./bin/altimate - Assert no 'opencode' bin entry exists
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Scope the release workflow test job to branding and install tests only, with --timeout 30000 for consistency with package.json. Prevents unrelated flaky tests from blocking releases while still catching branding regressions and packaging issues.
- Replace broken `curl altimate.ai/install` with `npm install -g @altimateai/altimate-code` (altimate.ai/install returns HTML, not a shell script) - Replace upstream TEAM_MEMBERS with actual AltimateAI collaborators so internal PRs skip the duplicate check
…ve TEAM_MEMBERS - Split symlink guard regex into two explicit assertions to prevent false positives (Unix symlink + Windows .exe checked independently) - Lowercase TEAM_MEMBERS entries and make grep case-insensitive (-i) since GitHub logins are case-insensitive
anandgupta42
added a commit
that referenced
this pull request
Mar 17, 2026
* fix: gate release workflow on tests and add build branding guards Release workflow: - Add test job (typecheck + bun test) that must pass before build/publish - Both build and publish-engine now depend on test job Branding guard tests (upstream-merge-guard.test.ts): - build.ts binary name is 'altimate' not 'opencode' - build.ts user-agent is 'altimate/' not 'opencode/' - build.ts embeds ALTIMATE_ENGINE_VERSION - build.ts reads engine version from pyproject.toml - build.ts creates altimate-code backward-compat symlink - build.ts has sourcemap: "external" - package.json bin entries are correct (no 'opencode') - package.json has no junk fields or echo-stub scripts - bin/opencode does not exist - keepOurs config includes build.ts, publish.ts, bin/**, CHANGELOG.md Publish package test: - Assert 'altimate' bin points to ./bin/altimate - Assert no 'opencode' bin entry exists * fix: scope release test job to release-critical tests only Scope the release workflow test job to branding and install tests only, with --timeout 30000 for consistency with package.json. Prevents unrelated flaky tests from blocking releases while still catching branding regressions and packaging issues. * fix: fix pr-management duplicate check and update TEAM_MEMBERS - Replace broken `curl altimate.ai/install` with `npm install -g @altimateai/altimate-code` (altimate.ai/install returns HTML, not a shell script) - Replace upstream TEAM_MEMBERS with actual AltimateAI collaborators so internal PRs skip the duplicate check * fix: address code review findings — regex precedence and case-sensitive TEAM_MEMBERS - Split symlink guard regex into two explicit assertions to prevent false positives (Unix symlink + Windows .exe checked independently) - Lowercase TEAM_MEMBERS entries and make grep case-insensitive (-i) since GitHub logins are case-insensitive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change
Issue for this PR
Closes #156
How did you verify your code works?
bun test test/branding/ test/install/publish-package.test.ts)Checklist
🤖 Generated with Claude Code