feat: add tracking to docs site using reodev and google tag manager#247
Merged
arora-saurabh448 merged 1 commit intomainfrom Mar 18, 2026
Merged
feat: add tracking to docs site using reodev and google tag manager#247arora-saurabh448 merged 1 commit intomainfrom
arora-saurabh448 merged 1 commit intomainfrom
Conversation
Claude Code ReviewThis repository is configured for manual code reviews. Comment |
|
|
||
| theme: | ||
| name: material | ||
| custom_dir: docs/overrides |
There was a problem hiding this comment.
Bug: The custom_dir is configured to be inside the docs_dir, which violates MkDocs constraints and will cause the documentation build to fail.
Severity: CRITICAL
Suggested Fix
Move the overrides directory to docs/overrides (making it a sibling to the documentation source files) and update the custom_dir setting in mkdocs.yml to overrides.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: docs/mkdocs.yml#L11
Potential issue: The `custom_dir` is set to `docs/overrides` in `mkdocs.yml`. Since the
`docs_dir` is not explicitly set, it defaults to `docs`, resolving to `docs/docs/`. This
makes the `custom_dir` path (`docs/docs/overrides/`) a subdirectory of the `docs_dir`.
MkDocs explicitly validates that the `custom_dir` must not be a child of the `docs_dir`.
This misconfiguration will cause a validation error during the build phase, preventing
the documentation from being generated.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What changed and why?
Test Plan
How was this tested?
Checklist