Skip to content

feat: add tracking to docs site using reodev and google tag manager#247

Merged
arora-saurabh448 merged 1 commit intomainfrom
feat/add_GA_RD_tracking
Mar 18, 2026
Merged

feat: add tracking to docs site using reodev and google tag manager#247
arora-saurabh448 merged 1 commit intomainfrom
feat/add_GA_RD_tracking

Conversation

@arora-saurabh448
Copy link
Collaborator

Summary

What changed and why?

Test Plan

How was this tested?

Checklist

  • Tests added/updated
  • Documentation updated (if needed)
  • CHANGELOG updated (if user-facing)

@claude
Copy link

claude bot commented Mar 18, 2026

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review.

@arora-saurabh448 arora-saurabh448 merged commit 66dab8b into main Mar 18, 2026
7 checks passed

theme:
name: material
custom_dir: docs/overrides
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The custom_dir is configured to be inside the docs_dir, which violates MkDocs constraints and will cause the documentation build to fail.
Severity: CRITICAL

Suggested Fix

Move the overrides directory to docs/overrides (making it a sibling to the documentation source files) and update the custom_dir setting in mkdocs.yml to overrides.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: docs/mkdocs.yml#L11

Potential issue: The `custom_dir` is set to `docs/overrides` in `mkdocs.yml`. Since the
`docs_dir` is not explicitly set, it defaults to `docs`, resolving to `docs/docs/`. This
makes the `custom_dir` path (`docs/docs/overrides/`) a subdirectory of the `docs_dir`.
MkDocs explicitly validates that the `custom_dir` must not be a child of the `docs_dir`.
This misconfiguration will cause a validation error during the build phase, preventing
the documentation from being generated.

Did we get this right? 👍 / 👎 to inform future reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant