feat: default auto_mcp_discovery to true#345
Conversation
The runtime behavior already defaulted to enabled (discovery runs unless explicitly set to false), but the Zod schema used `.optional()` which left the field as `undefined`. Switch to `.default(true)` so the schema matches the actual runtime default and serialized configs show the correct value. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The .default(true) change made the field required in Zod's output type, so test configs that construct experimental objects need the field. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThis change modifies the default behavior of auto MCP discovery by removing an explicit Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
No longer needed since the schema now defaults to true. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary
auto_mcp_discoveryZod schema from.boolean().optional()to.boolean().default(true)so the config schema explicitly reflects the runtime default (discovery was already enabled unless explicitly set tofalse)Test plan
bun turbo typecheckpassesauto_mcp_discoveryis not set in config"auto_mcp_discovery": falsedisables discovery🤖 Generated with Claude Code
Summary by CodeRabbit