Refactor permission and question services to use Effect#354
Open
anandgupta42 wants to merge 10000 commits intomainfrom
Open
Refactor permission and question services to use Effect#354anandgupta42 wants to merge 10000 commits intomainfrom
anandgupta42 wants to merge 10000 commits intomainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the permission and question request handling to use the Effect library for better composability and testability. The main changes include:
packages/opencode/src/permission/service.tsandpackages/opencode/src/question/service.tsthat implement permission and question request handling using Effect'sServiceMappatternpackages/opencode/src/permission/next.tsandpackages/opencode/src/question/index.tsto use the new service layer via theruntimeeffectPermissionRequesttype definition to the SDK's OpenAPI schema with proper validation patternsPermissionRequest,EventPermissionAsked, andEventPermissionRepliedtypesThe refactoring maintains backward compatibility while improving the internal architecture for better separation of concerns and testability.
Test Plan
Checklist
https://claude.ai/code/session_01FVE7bSfST5rpzbEmUhNiBU