test: add E2E smoke tests for skill CLI

[anandgupta42]

What does this PR do?

Adds committed E2E smoke tests that were previously only run as ad-hoc bash commands. These cover critical safety and lifecycle paths.

New tests (5):

• skill create → test → remove lifecycle — full lifecycle in isolated tmpdir
• cannot remove git-tracked skill — verifies git protection (the dbt-develop bug)
• symlinks are skipped during install copy — security regression test
• GitHub URL normalization — extracts owner/repo from web URLs
• .git suffix stripping — prevents double-append

Total: 26 tests, 91 assertions (was 21/75).

Type of change

• New feature (non-breaking change which adds functionality)

Issue for this PR

Closes #362

How did you verify your code works?

bun test test/cli/skill.test.ts — 26 pass, 0 fail

Checklist

• My code follows the style guidelines of this project
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

Summary by CodeRabbit

• Tests
  • Added comprehensive end-to-end smoke test suites for skill lifecycle operations, verifying tool detection and executability, proper handling of tracked and untracked skills during removal, symlink safety during installation copy procedures, and GitHub URL normalization including edge case handling for various URL formats.

[claude]

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 46281a21-ad35-43b1-ac45-089b237e9da4

📥 Commits

Reviewing files that changed from the base of the PR and between 46aada2 and 88e6de0.

📒 Files selected for processing (1)

• packages/opencode/test/cli/skill.test.ts

Disabled knowledge base sources:

• Jira integration is disabled

You can enable these sources in your CodeRabbit configuration.

---

📝 Walkthrough

Walkthrough

Added comprehensive end-to-end smoke tests for the skill CLI covering skill lifecycle management, git-tracked file protection, symlink safety during file copying, and GitHub URL normalization helper functions.

Changes

Cohort / File(s)	Summary
Skill CLI E2E Tests packages/opencode/test/cli/skill.test.ts	New test suites covering skill lifecycle (creation, tool detection, removal), git-tracked file protection, symlink safety during install/copy operations, and GitHub URL parsing with regex-based normalization and .git suffix stripping.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

• feat: add skill CLI command and .opencode/tools/ auto-discovery #342: Implements the skill CLI behaviors and helper logic (detectToolReferences, install/copy safety) that these new tests validate.
• fix: bundle skills, dbt-tools, and altimate-setup in shipped npm binary #316: Introduces builtin-skill bundling, install/copy handling, and skill loader features that these tests exercise and verify.

Suggested labels

contributor

Poem

🐰 A bundled skill takes shape today,
With tests to guide it on its way,
Git-tracked treasures stay secure,
Symlinks leashed—our tools endure.
URLs parsed with regex cheer,
The skill CLI shines bright and clear! ✨

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/add-smoke-tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}