chore: improve test-discovery skill with PR docs and TUI E2E guidance

[anandgupta42]

What does this PR do?

Updates the /test-discovery skill with two new rules and a revamped PR template, based on issues found during the first automated test sweep run.

Changes

Revamped PR template (Phase 5)

The previous template produced low-quality one-liner descriptions like "Adds tests for [area] discovered by hourly test sweep." The new template requires:

• A per-module breakdown listing the source file path and test count
• An explanation of why the module was untested and what user-facing risk the tests mitigate
• Specific test scenarios listed per module
• A concrete example baked into the template so the agent follows the format
• Pass counts per test file in the verification section

New Rule 9 — TUI E2E impact check

When tests touch code that feeds into the TUI (session state, config, skills, tools, MCP, providers), the skill now requires checking whether the TUI could be affected and adding E2E tests for those paths. Points to packages/opencode/test/config/tui.test.ts as a reference. TUI regressions are high-visibility since it's the primary user interface.

New Rule 10 — PR documentation standard

Explicitly codifies that one-liner PR bodies are not acceptable. Every PR must explain what was tested, why, and what risk is mitigated.

Type of change

• New feature (non-breaking change which adds functionality)

Issue for this PR

N/A — process improvement

How did you verify your code works?

Documentation-only change to a .claude/commands/ skill file. Verified markdown renders correctly.

Checklist

• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

https://claude.ai/code/session_01AkMKqcoyJ1vURZ4crtpEZu

Summary by CodeRabbit

• Documentation
  • Enhanced PR template to require comprehensive test documentation, including multi-module descriptions specifying which areas were tested, previously untested gaps, user-facing risks mitigated, and concrete test scenarios covered.
  • Updated test verification requirements to list individual test files with pass counts and added mandatory TUI impact assessment checks.

[claude]

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: d3a411c1-6ae7-44d1-998b-095ed3b3c38f

📥 Commits

Reviewing files that changed from the base of the PR and between d486295 and 0bd3521.

📒 Files selected for processing (1)

• .claude/commands/test-discovery.md

Disabled knowledge base sources:

• Jira integration is disabled

You can enable these sources in your CodeRabbit configuration.

---

📝 Walkthrough

Walkthrough

The PR template in .claude/commands/test-discovery.md is expanded to require contributors to provide comprehensive test documentation, including detailed module descriptions, specific scenarios covered, and test file pass counts, plus new checklist items for TUI impact verification.

Changes

Cohort / File(s)	Summary
Test Discovery Template .claude/commands/test-discovery.md	Expanded PR template to mandate detailed multi-module test documentation, including module names, untested area rationale, user-facing risk mitigation, concrete test scenarios, individual test file listings with pass counts, and new checklist items for TUI impact validation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested labels

contributor

Poem

🐰 Tests now documented with care,
Module by module, scenario fair,
Pass counts listed, no stone left bare,
TUI checked with rabbit flair,
Better testing standards in the air! ✨

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/update-test-discovery-skill-session_01AkMKqcoyJ1vURZ4crtpEZu

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}