test: MongoDB config normalization aliases — 13 new tests

[anandgupta42]

What does this PR do?

1. normalizeConfig — MongoDB aliases — packages/drivers/src/normalize.ts (13 new tests)

MongoDB was added as the 11th supported driver in PR #482 (commit abcaa1d), but the config normalization alias map (MONGODB_ALIASES) had zero unit test coverage. Every other driver (Snowflake, BigQuery, Databricks, Postgres, Redshift, MySQL, SQL Server, Oracle, DuckDB, SQLite) already had dedicated normalization tests in driver-normalize.test.ts.

Why this matters: Users providing MongoDB configs via dbt profiles, LLM-generated configs, or SDK conventions use camelCase keys (connectionString, authSource, replicaSet, directConnection). Without normalization, these keys silently pass through unresolved, causing connection failures with no clear error message. The mongo type alias (shorthand for mongodb) was also untested.

Specific scenarios covered:

• Connection string aliases: connectionString, uri, url → connection_string (3 tests)
• First-value-wins precedence: canonical connection_string takes priority over uri alias (1 test)
• MongoDB-specific aliases: authSource → auth_source, replicaSet → replica_set, directConnection → direct_connection, connectTimeoutMS → connect_timeout, serverSelectionTimeoutMS → server_selection_timeout (5 tests)
• Common aliases for MongoDB: username → user, dbname → database (2 tests)
• Type alias: mongo resolves to the same alias map as mongodb (1 test)
• Identity: canonical MongoDB config passes through unchanged (1 test)

Test quality: All tests are pure-function unit tests with no network, timing, or filesystem dependencies. Reviewed and approved by a critic agent before committing.

Type of change

• New feature (non-breaking change which adds functionality)

Issue for this PR

N/A — proactive test coverage for newly added MongoDB driver

How did you verify your code works?

bun test test/altimate/driver-normalize.test.ts    # 91 pass (78 existing + 13 new)

Checklist

• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

https://claude.ai/code/session_019D8HyMGHH3Pf43PddTqUw5

Summary by CodeRabbit

• Tests
  • Added extensive test coverage for MongoDB configuration normalization, validating proper handling of connection parameters (connection strings and URIs), authentication fields, replica set settings, timeout configurations, and connection modes to ensure consistent configuration validation.

[claude]

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review.

_{Tip: disable this comment in your organization's Code Review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

A new MongoDB-specific configuration alias normalization test suite was added, covering field mappings such as connectionString → connection_string, authSource → auth_source, replicaSet → replica_set, timeout fields, and username/dbname transformations, with assertions for precedence and canonical config passthrough.

Changes

Cohort / File(s)	Summary
MongoDB Alias Normalization Tests packages/opencode/test/altimate/driver-normalize.test.ts	Added 130 lines of test cases covering MongoDB configuration alias mappings, including connection string variants, authentication fields, replica set, direct connection, timeout fields, and username/database transformations, with assertions for field precedence and canonical config validation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• feat: add MongoDB driver support #482: Implements the MongoDB alias normalization mappings in the normalize.ts driver that these new test cases validate.

Suggested labels

contributor

Poem

🐰 Hops of joy through MongoDB fields so bright,
Aliases dance—connection strings unite!
authSource springs to auth_source with care,
Timeouts normalized in the testing air! 🥕

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change: adding 13 new tests for MongoDB config normalization aliases.
Description check	✅ Passed	The description covers what changed, includes detailed test scenarios, and mentions local verification with test results, but lacks explicit Test Plan and Checklist sections matching the template structure.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch test/hourly-20260326-2013

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

packages/opencode/test/altimate/driver-normalize.test.ts (1)

693-709: Consider pinning alias-order behavior when both uri and url are present.

You already test canonical-over-alias precedence. Adding one case with both non-canonical aliases would lock in the current first-alias-wins order and prevent future regressions in alias-list ordering.

Proposed additional test

 describe("normalizeConfig — MongoDB", () => {
+  test("uri takes precedence over url when both aliases are present", () => {
+    const result = normalizeConfig({
+      type: "mongodb",
+      uri: "mongodb://uri-first:27017/db",
+      url: "mongodb://url-second:27017/db",
+    })
+    expect(result.connection_string).toBe("mongodb://uri-first:27017/db")
+    expect(result.uri).toBeUndefined()
+    expect(result.url).toBeUndefined()
+  })
+
   test("canonical mongodb config passes through unchanged", () => {

Also applies to: 711-719

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/opencode/test/altimate/driver-normalize.test.ts` around lines 693 -
709, Add a test to pin current alias-resolution order when both non-canonical
aliases are present: call normalizeConfig with both uri and url set (e.g., uri
first, url second) and assert that connection_string equals the first alias
value and the second alias is undefined; use a clear test name like "uri+url →
first-alias-wins" referencing normalizeConfig so future changes to alias
ordering will fail the test if behavior changes.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@packages/opencode/test/altimate/driver-normalize.test.ts`:
- Around line 693-709: Add a test to pin current alias-resolution order when
both non-canonical aliases are present: call normalizeConfig with both uri and
url set (e.g., uri first, url second) and assert that connection_string equals
the first alias value and the second alias is undefined; use a clear test name
like "uri+url → first-alias-wins" referencing normalizeConfig so future changes
to alias ordering will fail the test if behavior changes.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: a5339c36-4ff2-40a3-835f-b194ce636097

📥 Commits

Reviewing files that changed from the base of the PR and between abcaa1d and 78b50c7.

📒 Files selected for processing (1)

• packages/opencode/test/altimate/driver-normalize.test.ts

[anandgupta42]

Consolidated into #498. Tests deduplicated and merged into a single PR.