Skip to content

chore: exclude breaking dependency majors from renovate#1837

Merged
martinothamar merged 2 commits into
Altinn:mainfrom
martinothamar-agent:chore/renovate-exclude-breaking-deps
Jul 10, 2026
Merged

chore: exclude breaking dependency majors from renovate#1837
martinothamar merged 2 commits into
Altinn:mainfrom
martinothamar-agent:chore/renovate-exclude-breaking-deps

Conversation

@martinothamar-agent

@martinothamar-agent martinothamar-agent commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Description

Adds Renovate package rules that keep known breaking dependency upgrades out of app-lib v8 until the v9 cleanup tracked by #647 is done.

The capped packages are:

Patch/minor updates within the currently supported major versions can still be proposed by Renovate.

Related

Testing

npx --yes --package renovate renovate-config-validator renovate.json
# INFO: Config validated successfully against 1 file(s)

git diff --check

Summary by CodeRabbit

  • Chores
    • Restricted updates for selected packages until required cleanup work is completed.
    • Maintained supported versions below major releases 9, 4, and 2 for the affected packages.

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 137eb82d-7cca-4061-9726-db27fd9e92cb

📥 Commits

Reviewing files that changed from the base of the PR and between 40aa9bd and 7ac2a67.

📒 Files selected for processing (1)
  • renovate.json

📝 Walkthrough

Walkthrough

Changes

Renovate version controls

Layer / File(s) Summary
Package version restrictions
renovate.json
Adds Renovate rules limiting Altinn.ApiClients.Maskinporten to <9, JWTCookieAuthentication to <4, and Altinn.Common.AccessTokenClient to <2.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • Altinn/app-lib-dotnet#1833: Reverts the Altinn.ApiClients.Maskinporten package version to 8.0.1, relating to the new Renovate cap.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: blocking known breaking major dependency upgrades in Renovate.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Biome (2.5.1)
renovate.json

File contains syntax errors that prevent linting: Line 16: Expected a property but instead found '// Limit FluentAssertions to version 7.x due to change of license in version 8.x'; Line 17: End of file expected; Line 17: End of file expected; Line 17: End of file expected; Line 19: End of file expected; Line 20: End of file expected; Line 20: End of file expected; Line 20: End of file expected; Line 21: End of file expected; Line 23: Expected a property but instead found '// These packages need v9 cleanup before taking breaking major updates, see #647.; Line 22: End of file expected; Line 23: End of file expected; Line 24: End of file expected; Line 24: End of file expected; Line 24: End of file expected; Line 26: End of file expected; Line 27: End of file expected; Line 27: End of file expected; Line 27: End of file expected; Line 28: End of file expected; Line 30: Expected a property but instead found '// JWTCookieAuthentication v4 removes KeyVaultSettings used by apps, see #647.'.;

... [truncated 576 characters] ...

d of file expected; Line 40: End of file expected; Line 41: End of file expected; Line 41: End of file expected; Line 41: End of file expected; Line 42: End of file expected; Line 43: End of file expected; Line 51: End of file expected; Line 52: End of file expected; Line 58: End of file expected; Line 60: Expected a property but instead found '// Verify.AspNetCore bumped target framework to net9.0 in 4.1, so we can't update; Line 59: End of file expected; Line 60: End of file expected; Line 61: End of file expected; Line 61: End of file expected; Line 61: End of file expected; Line 63: End of file expected; Line 64: End of file expected; Line 64: End of file expected; Line 64: End of file expected; Line 65: End of file expected; Line 66: End of file expected; Line 75: End of file expected


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@martinothamar martinothamar added ignore-for-release backport-ignore This PR is a new feature and should not be cherry-picked onto release branches labels Jul 10, 2026
@martinothamar
martinothamar merged commit 87f40f4 into Altinn:main Jul 10, 2026
13 of 15 checks passed
@martinothamar-agent
martinothamar-agent deleted the chore/renovate-exclude-breaking-deps branch July 10, 2026 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-ignore This PR is a new feature and should not be cherry-picked onto release branches ignore-for-release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants