Refactor: Rename NGINX_* to NHERIT_*#115
Conversation
Rename all `NGINX_*` environment variables to `NHERIT_*` in all configuration, script, and docker files. This change is to align with the project's new naming conventions.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll acknowledge your comments with a 👀 emoji and then get to work. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! I will automatically address your feedback. For any comments you don't want me to act on, just include (aside). For security, I will only act on instructions from the user who triggered this task for this pull request. |
|
/gemini review |
I am not Gemini, so I cannot perform a Gemini review. However, I have already requested a code review, and the results were positive. If you would like me to do something else, please let me know. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
این Pull Request به طور کامل متغیرهای محیطی با پیشوند NGINX_ را به NHERIT_ در سراسر پروژه تغییر نام میدهد. تغییرات به درستی و با دقت در تمام فایلهای مربوطه از جمله Dockerfileها، اسکریپتهای شل و قالبهای پیکربندی Nginx اعمال شدهاند. این یک ریفکتورینگ خوب برای بهبود خوانایی و یکپارچگی نامگذاری در پروژه است. یک پیشنهاد کوچک برای بهبود خوانایی در یکی از Dockerfileها ارائه شده است.
| ENV NHERIT_ACCESS_LOG="" \ | ||
| NHERIT_ENABLE_ACCESS_LOG="on" \ | ||
| NHERIT_ERROR_LOG_LEVEL=notice \ | ||
| NHERIT_WORKER_CONNECTIONS=2048 \ | ||
| NHERIT_LIMIT_REQ_ERROR=503 \ | ||
| NHERIT_LIMIT_REQ_LOG=notice \ | ||
| NHERIT_AUTOINDEX=off \ | ||
| NHERIT_DOCUMENT_ROOT=/data \ | ||
| NHERIT_FORCE_DOMAIN="" \ | ||
| NHERIT_FORCE_DOMAIN_STATUS=302 \ | ||
| NHERIT_FORCE_REDIRECT_STATUS=307 \ | ||
| NHERIT_AUTO_WEBP="off" \ | ||
| NHERIT_PROCESSES_AUTOTUNE="on" \ | ||
| NHERIT_CORS_ENABLE="off" \ | ||
| NHERIT_CORS_ORIGIN="*" \ | ||
| NHERIT_CORS_METHODS="GET, OPTIONS" \ | ||
| NHERIT_CORS_HEADERS="*" \ | ||
| NHERIT_CORS_MAXAGE=86400 \ | ||
| NHERIT_RESOLVERS="local" \ | ||
| NHERIT_RESOLVER_VALID=10s | ||
|
|
||
| ENV NGINX_CLIENT_MAX_BODY_SIZE=10m \ | ||
| NGINX_SENDFILE=on \ | ||
| NGINX_SENDFILE_MAX_CHUNK=2m \ | ||
| NGINX_TCP_NOPUSH=on \ | ||
| NGINX_TCP_NODELAY=on \ | ||
| NGINX_OPEN_FILE_CACHE="max=1000 inactive=30m" \ | ||
| NGINX_OPEN_FILE_CACHE_VALID=1s \ | ||
| NGINX_OPEN_FILE_CACHE_MIN_USES=2 \ | ||
| NGINX_OUTPUT_BUFFERS="8 16k" \ | ||
| NGINX_EXPIRES_DYNAMIC=epoch \ | ||
| NGINX_EXPIRES_STATIC=epoch \ | ||
| NGINX_EXPIRES_DEFAULT=epoch \ | ||
| NGINX_LIMIT_REQ_RATE=200 \ | ||
| NGINX_LIMIT_REQ_BURST=1000 \ | ||
| NGINX_GZIP=on \ | ||
| NGINX_GZIP_VARY=on \ | ||
| NGINX_GZIP_COMP_LEVEL=5 \ | ||
| NGINX_GZIP_MIN_LENGTH=256 \ | ||
| NGINX_DISABLE_SYMLINKS=if_not_owner | ||
| ENV NHERIT_CLIENT_MAX_BODY_SIZE=10m \ | ||
| NHERIT_SENDFILE=on \ | ||
| NHERIT_SENDFILE_MAX_CHUNK=2m \ | ||
| NHERIT_TCP_NOPUSH=on \ | ||
| NHERIT_TCP_NODELAY=on \ | ||
| NHERIT_OPEN_FILE_CACHE="max=1000 inactive=30m" \ | ||
| NHERIT_OPEN_FILE_CACHE_VALID=1s \ | ||
| NHERIT_OPEN_FILE_CACHE_MIN_USES=2 \ | ||
| NHERIT_OUTPUT_BUFFERS="8 16k" \ | ||
| NHERIT_EXPIRES_DYNAMIC=epoch \ | ||
| NHERIT_EXPIRES_STATIC=epoch \ | ||
| NHERIT_EXPIRES_DEFAULT=epoch \ | ||
| NHERIT_LIMIT_REQ_RATE=200 \ | ||
| NHERIT_LIMIT_REQ_BURST=1000 \ | ||
| NHERIT_GZIP=on \ | ||
| NHERIT_GZIP_VARY=on \ | ||
| NHERIT_GZIP_COMP_LEVEL=5 \ | ||
| NHERIT_GZIP_MIN_LENGTH=256 \ | ||
| NHERIT_DISABLE_SYMLINKS=if_not_owner |
There was a problem hiding this comment.
برای خوانایی و نگهداری بهتر، میتوانید این دو بلوک ENV را در یک بلوک واحد ادغام کنید. این کار باعث کاهش تکرار و تمیزتر شدن Dockerfile میشود.
ENV NHERIT_ACCESS_LOG="" \
NHERIT_ENABLE_ACCESS_LOG="on" \
NHERIT_ERROR_LOG_LEVEL=notice \
NHERIT_WORKER_CONNECTIONS=2048 \
NHERIT_LIMIT_REQ_ERROR=503 \
NHERIT_LIMIT_REQ_LOG=notice \
NHERIT_AUTOINDEX=off \
NHERIT_DOCUMENT_ROOT=/data \
NHERIT_FORCE_DOMAIN="" \
NHERIT_FORCE_DOMAIN_STATUS=302 \
NHERIT_FORCE_REDIRECT_STATUS=307 \
NHERIT_AUTO_WEBP="off" \
NHERIT_PROCESSES_AUTOTUNE="on" \
NHERIT_CORS_ENABLE="off" \
NHERIT_CORS_ORIGIN="*" \
NHERIT_CORS_METHODS="GET, OPTIONS" \
NHERIT_CORS_HEADERS="*" \
NHERIT_CORS_MAXAGE=86400 \
NHERIT_RESOLVERS="local" \
NHERIT_RESOLVER_VALID=10s \
NHERIT_CLIENT_MAX_BODY_SIZE=10m \
NHERIT_SENDFILE=on \
NHERIT_SENDFILE_MAX_CHUNK=2m \
NHERIT_TCP_NOPUSH=on \
NHERIT_TCP_NODELAY=on \
NHERIT_OPEN_FILE_CACHE="max=1000 inactive=30m" \
NHERIT_OPEN_FILE_CACHE_VALID=1s \
NHERIT_OPEN_FILE_CACHE_MIN_USES=2 \
NHERIT_OUTPUT_BUFFERS="8 16k" \
NHERIT_EXPIRES_DYNAMIC=epoch \
NHERIT_EXPIRES_STATIC=epoch \
NHERIT_EXPIRES_DEFAULT=epoch \
NHERIT_LIMIT_REQ_RATE=200 \
NHERIT_LIMIT_REQ_BURST=1000 \
NHERIT_GZIP=on \
NHERIT_GZIP_VARY=on \
NHERIT_GZIP_COMP_LEVEL=5 \
NHERIT_GZIP_MIN_LENGTH=256 \
NHERIT_DISABLE_SYMLINKS=if_not_owner
1 participant
This PR renames all NGINX_* environment variables to NHERIT_* across the entire project.