Open
Conversation
Alystrasz
requested changes
Feb 2, 2023
Owner
Alystrasz
left a comment
Alystrasz
left a comment
There was a problem hiding this comment.
Thanks for the PR, I'll have some time next week to review it properly.
| public class SwiftBluetoothEnablePlugin: NSObject, FlutterPlugin, CBCentralManagerDelegate { | ||
| var centralManager: CBCentralManager! | ||
| var lastKnownState: CBManagerState! | ||
| var lastKnownState = "" |
Owner
There was a problem hiding this comment.
What's the difference between not initializing lastKnownState and set it to ""?
Author
There was a problem hiding this comment.
'CBManagerState' is only available in iOS 10.0 or newer
So i avoid using it
Author
|
Hey @Alystrasz it should be good now, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Alystrasz first thank you for forking this initially
I presume there are not so many coconuts out there caring for retrocompat,
If by any chance you wish to walk along this dusty road
Indulge me by accepting this PR