feat(docs): add vitepress-plugin-enhanced-readabilities - #31
Merged
Conversation
Contributor
Reviewer's GuideIntegrates the @nolebase/vitepress-plugin-enhanced-readabilities into the docs site and reworks the VitePress theme to use AmritaSense-specific design tokens and UI styling for layout, navigation, buttons, home hero, and content elements. Sequence diagram for rendering layout with enhanced readabilities menussequenceDiagram
actor User
participant DocsSite
participant VitepressTheme as Theme.Layout
participant DefaultLayout as DefaultTheme.Layout
participant NavMenu as NolebaseEnhancedReadabilitiesMenu
participant ScreenMenu as NolebaseEnhancedReadabilitiesScreenMenu
User->>DocsSite: request docs page
DocsSite->>VitepressTheme: render Layout()
VitepressTheme->>DefaultLayout: h(DefaultTheme.Layout)
VitepressTheme->>DefaultLayout: provide slot nav-bar-content-after
DefaultLayout->>NavMenu: render NolebaseEnhancedReadabilitiesMenu
VitepressTheme->>DefaultLayout: provide slot nav-screen-content-after
DefaultLayout->>ScreenMenu: render NolebaseEnhancedReadabilitiesScreenMenu
DefaultLayout->>User: send page with enhanced readabilities controls
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Deploying amritasense with
|
| Latest commit: |
e757d9d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5689a0df.amritasense.pages.dev |
| Branch Preview URL: | https://feat-style.amritasense.pages.dev |
JohnRichard4096
force-pushed
the
feat-style
branch
from
July 22, 2026 09:59
256827a to
15babe6
Compare
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- In
var.cssyou now rely on--vp-c-gray-*variables without defining them locally; consider either importing or redefining these gray tokens to avoid unexpected styling issues if VitePress changes its defaults. - Several colors in
custom.css(e.g. button text#ffffff, gold accents) are hardcoded instead of using design tokens; aligning these with the variables invar.csswould make future theme adjustments and brand updates easier.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `var.css` you now rely on `--vp-c-gray-*` variables without defining them locally; consider either importing or redefining these gray tokens to avoid unexpected styling issues if VitePress changes its defaults.
- Several colors in `custom.css` (e.g. button text `#ffffff`, gold accents) are hardcoded instead of using design tokens; aligning these with the variables in `var.css` would make future theme adjustments and brand updates easier.
## Individual Comments
### Comment 1
<location path="docs/.vitepress/theme/var.css" line_range="83-92" />
<code_context>
- /* border-color: #d97706; */
- border-color: var(--vp-c-yellow-2);
+ /* Status colors */
+ --vp-c-tip-1: #c8a454;
+ --vp-c-tip-2: #b3943a;
+ --vp-c-tip-3: #9a7d2e;
+
+ --vp-c-warning-1: #e6c17a;
+ --vp-c-warning-2: #d4a84d;
+ --vp-c-warning-3: #b89030;
+
+ --vp-c-danger-1: #e05555;
+ --vp-c-danger-2: #c44040;
+ --vp-c-danger-3: #a03030;
+
+ --vp-c-default-1: var(--vp-c-gray-1);
+ --vp-c-default-2: var(--vp-c-gray-2);
+ --vp-c-default-3: var(--vp-c-gray-3);
+ --vp-c-default-soft: var(--vp-c-gray-soft);
}
</code_context>
<issue_to_address>
**issue (bug_risk):** Soft variants for tip/warning/danger status colors are no longer defined, which might break built-in VitePress theming that references them.
`--vp-c-tip-soft`, `--vp-c-warning-soft`, and `--vp-c-danger-soft` used to be defined and are referenced by VitePress core/themes for status block and badge backgrounds. With the new palette only `*-1/2/3` are present, so those references may resolve to unset values or defaults. Please add corresponding `*-soft` variants in `var.css`, aligned with the new status colors, to preserve VitePress compatibility.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
JohnRichard4096
force-pushed
the
feat-style
branch
from
July 22, 2026 10:06
4d05b35 to
6a0b99d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Integrate the Nolebase enhanced readability plugin into the VitePress docs theme and apply a refreshed AmritaSense visual design.
New Features:
Enhancements: