Skip to content

Update sdk to sourcemod maintained version#64

Draft
sapphonie wants to merge 16 commits intoAnAkkk:publicfrom
sapphonie:updatesdk
Draft

Update sdk to sourcemod maintained version#64
sapphonie wants to merge 16 commits intoAnAkkk:publicfrom
sapphonie:updatesdk

Conversation

@sapphonie
Copy link
Contributor

These sdks are maintained by the Sourcemod team, meaning that it's going to be significantly easier to update TFTrue if a tf2 update comes along, as other coders rely on these sdks as well.

@sapphonie
Copy link
Contributor Author

sapphonie commented May 14, 2022

Also, you should consider enabling building with optimized debug syms.

TFTrue still tends to crash, randomly, a lot. Enabling syms would make debugging crash dumps so much easier.

@sapphonie sapphonie marked this pull request as draft May 14, 2022 19:38
@sapphonie sapphonie changed the title Update sdk to sourcemod maintained versions Update sdk to sourcemod maintained version May 16, 2022
@sapphonie sapphonie marked this pull request as ready for review May 17, 2022 03:51
# https://github.com/alliedmodders/hl2sdk/pull/99
rm ./hl2sdk-tf2/game/shared/gamemovement.h
# permalink to this commit
curl https://raw.githubusercontent.com/sapphonie/hl2sdk/10934b8c9edf900850b1d85f1b9eff90addc0084/game/shared/gamemovement.h -o ./hl2sdk-tf2/game/shared/gamemovement.h
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meant to be part of the PR? I would not include it as it adds a dependency on your repository.

Copy link
Contributor Author

@sapphonie sapphonie May 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could (and should) just fork the hl2sdk-2013 repo sourcemod uses, checkout the tf2 branch, and add the updated steamworks http headers to it (https://partner.steamgames.com/downloads/steamworks_sdk.zip), and then add the single fix i pr'd to alliedmodders so it'll compile.

i have done the following already at

https://github.com/sapphonie/hl2sdk/tree/tftrue-tf2

you can compare it to the alliedmodders repo @

alliedmodders/hl2sdk@tf2...sapphonie:tftrue-tf2

Copy link
Contributor Author

@sapphonie sapphonie May 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can also just remove this script, it's something i added before i forked the alliedmodders hl2sdk-tf2 myself for tftruer, lol

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the fix was merged now. Are the updated steamworks http headers needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@sapphonie sapphonie marked this pull request as draft May 31, 2022 11:33
@sapphonie
Copy link
Contributor Author

sapphonie commented May 31, 2022

Honestly don't merge this as is. Itd be better using something like https://github.com/TF2-DMB/hl2sdk-tf2, since alliedmodders tf2 branch is STILL out of date on a lot of stuff, which is likely why my tftrue fork still tends to crash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants