Update sdk to sourcemod maintained version#64
Update sdk to sourcemod maintained version#64sapphonie wants to merge 16 commits intoAnAkkk:publicfrom
Conversation
|
Also, you should consider enabling building with optimized debug syms. TFTrue still tends to crash, randomly, a lot. Enabling syms would make debugging crash dumps so much easier. |
| # https://github.com/alliedmodders/hl2sdk/pull/99 | ||
| rm ./hl2sdk-tf2/game/shared/gamemovement.h | ||
| # permalink to this commit | ||
| curl https://raw.githubusercontent.com/sapphonie/hl2sdk/10934b8c9edf900850b1d85f1b9eff90addc0084/game/shared/gamemovement.h -o ./hl2sdk-tf2/game/shared/gamemovement.h |
There was a problem hiding this comment.
Is this meant to be part of the PR? I would not include it as it adds a dependency on your repository.
There was a problem hiding this comment.
You could (and should) just fork the hl2sdk-2013 repo sourcemod uses, checkout the tf2 branch, and add the updated steamworks http headers to it (https://partner.steamgames.com/downloads/steamworks_sdk.zip), and then add the single fix i pr'd to alliedmodders so it'll compile.
i have done the following already at
https://github.com/sapphonie/hl2sdk/tree/tftrue-tf2
you can compare it to the alliedmodders repo @
There was a problem hiding this comment.
you can also just remove this script, it's something i added before i forked the alliedmodders hl2sdk-tf2 myself for tftruer, lol
There was a problem hiding this comment.
Seems like the fix was merged now. Are the updated steamworks http headers needed?
|
Honestly don't merge this as is. Itd be better using something like https://github.com/TF2-DMB/hl2sdk-tf2, since alliedmodders tf2 branch is STILL out of date on a lot of stuff, which is likely why my tftrue fork still tends to crash |
These sdks are maintained by the Sourcemod team, meaning that it's going to be significantly easier to update TFTrue if a tf2 update comes along, as other coders rely on these sdks as well.