Add devcontainer-bridge (dbr) for dynamic port forwarding#13
Add devcontainer-bridge (dbr) for dynamic port forwarding#13AnExiledDev merged 2 commits intomainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughAdds devcontainer-bridge (dbr) support: an Unreleased changelog entry announcing dynamic in-container port discovery and forwarding (requires a host-daemon), documents the Changes
Sequence Diagram(s)mermaid Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.devcontainer/CHANGELOG.md:
- Around line 5-7: Under the "### Added" section add a `####` sub-heading (e.g.,
"#### Features") and replace the implementation-focused bullet about
"devcontainer-bridge (dbr)" with a user-facing description: keep the identifier
"devcontainer-bridge (dbr)" and the requirement "requires `dbr host-daemon`
running on the host machine" but reword the rest to state the user-visible
change (what it enables for users, e.g., automatic discovery and forwarding of
container ports to the host) instead of describing the internal
polling/reverse-TCP mechanism.
In @.devcontainer/CLAUDE.md:
- Around line 104-107: The "Dynamic Discovery" column incorrectly marks
`forwardPorts` (in `devcontainer.json`) as "Yes"; update the table so
`forwardPorts` is shown as static (e.g., "No" or "Static declaration") and add a
brief parenthetical or footnote clarifying that VS Code's separate auto
port-forwarding feature performs runtime discovery of listeners (this is
distinct from the `forwardPorts` static setting), while `devcontainer-bridge`
(`dbr`) remains the dynamic mechanism that polls `/proc/net/tcp`.
In @.devcontainer/devcontainer.json:
- Line 139: Replace the unpinned image reference
"ghcr.io/bradleybeddoes/devcontainer-bridge/dbr:latest" with a specific,
immutable version tag (e.g., match the semver style used for other images like
"node:1.7.1" or pick the latest known stable dbr release) so the devcontainer
becomes reproducible; update the string in the devcontainer features list to use
"ghcr.io/bradleybeddoes/devcontainer-bridge/dbr:<version>" and ensure the chosen
version is committed in the file (not ":latest").
forwardPorts in devcontainer.json is a no-op outside VS Code. dbr provides dynamic port auto-discovery via /proc/net/tcp polling and forwards to the host via reverse TCP connections. Container daemon is inert without the host daemon, so VS Code users are unaffected.
- CHANGELOG: add #### Features sub-heading, rewrite bullet as user-facing - CLAUDE.md: forwardPorts is static, not dynamic discovery - CLAUDE.md: fix Claude Code version ref (:1 → :1.0.5) - devcontainer.json: pin dbr to 0.2.0 instead of :latest
be87c2d to
5b3a9c0
Compare
Summary
dbr) as an external devcontainer feature/proc/net/tcp, reverse TCP forwarding to host)dbr host-daemon— VS Code users unaffectedforwardPortsretained for VS Code notify UX; both mechanisms coexistChanges
devcontainer.json— addedghcr.io/bradleybeddoes/devcontainer-bridge/dbr:latestto features and install orderCHANGELOG.md— added[Unreleased]entryCLAUDE.md— addeddbrcommand and Port Forwarding sectionTest plan
which dbrreturns a pathdbr container-daemon --helpworks inside containerforwardPortsstill works as beforeSummary by CodeRabbit
New Features
Documentation