fix(chromaterm): replace alternation in lookbehinds for PCRE2 compat#18
Merged
AnExiledDev merged 1 commit intomainfrom Feb 26, 2026
Merged
fix(chromaterm): replace alternation in lookbehinds for PCRE2 compat#18AnExiledDev merged 1 commit intomainfrom
AnExiledDev merged 1 commit intomainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughTwo regex patterns in the ChromaTerm configuration were updated to fix compatibility with Python's Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
PCRE2 requires fixed-length lookbehinds. The file path regex used `(?<=[\s(]|^)` (variable-length alternation) and the git hash regex used `(?<=commit |merge |...)` (different-length alternatives). Replaced with non-capturing groups containing individual fixed-length lookbehinds that satisfy the PCRE2 constraint. Closes #15
97b4506 to
0fb0668
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chromaterm.ymlused variable-length alternation patterns(?<=[\s(]|^)→(?:(?<=[\s(])|^)(zero-width^can't mix with\s()(?<=commit |merge |pick |revert |fixup )→ individual lookbehinds in non-capturing groupCloses #15
Test plan
ctparses the updated YAML without errorssrc/main.py:42still highlight correctlycommit,merge,pick,revert,fixupstill highlightSummary by CodeRabbit