Fix ccstatusline line 1 styling and readability#9
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review infoConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughConfiguration and documentation updates: status-line JSON gains labeled token widgets and rawValue/color/bgColor tweaks; CHANGELOG and CLAUDE.md updated with new status bar widget docs and visual/behavior notes. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.devcontainer/config/defaults/ccstatusline-settings.json:
- Around line 23-85: The PR changed statusline config behavior and conventions
but no docs were updated; add/update CLAUDE.md to document the new keys and
conventions: describe the new widget types ("tokens-input", "tokens-output",
"tokens-cached", "tokens-total", and "custom-text" label entries like
"lbl-tokens-input"/"lbl-tokens-output"/"lbl-tokens-cached"/"lbl-tokens-total"),
the new properties used ("rawValue", "merge": "no-padding", "backgroundColor"
and color conventions like bgBlue/bgMagenta/bgYellow/bgGreen and
brightWhite/black), and provide a minimal example snippet mirroring the diff
plus a short migration note explaining expected behavior changes and how to
add/update statusline entries.
| { | ||
| "id": "lbl-tokens-input", | ||
| "type": "custom-text", | ||
| "customText": "In", | ||
| "backgroundColor": "bgBlue", | ||
| "color": "brightWhite", | ||
| "bold": true, | ||
| "merge": "no-padding" | ||
| }, | ||
| { | ||
| "id": "5", | ||
| "type": "tokens-input", | ||
| "color": "magenta", | ||
| "rawValue": true, | ||
| "backgroundColor": "bgBlue", | ||
| "color": "brightWhite", | ||
| "rawValue": true | ||
| }, | ||
| { | ||
| "id": "lbl-tokens-output", | ||
| "type": "custom-text", | ||
| "customText": "Ou", | ||
| "backgroundColor": "bgMagenta", | ||
| "color": "brightWhite", | ||
| "bold": true, | ||
| "merge": "no-padding" | ||
| }, | ||
| { | ||
| "id": "ac094d46-3673-4d41-84e3-dc8c5bcf639f", | ||
| "type": "tokens-output", | ||
| "backgroundColor": "bgMagenta", | ||
| "rawValue": true, | ||
| "color": "brightWhite", | ||
| "rawValue": true | ||
| }, | ||
| { | ||
| "id": "lbl-tokens-cached", | ||
| "type": "custom-text", | ||
| "customText": "Ca", | ||
| "backgroundColor": "bgYellow", | ||
| "color": "black", | ||
| "bold": true, | ||
| "merge": "no-padding" | ||
| }, | ||
| { | ||
| "id": "2ad12147-05fd-45fb-8336-53ba2e7df56c", | ||
| "type": "tokens-cached", | ||
| "backgroundColor": "bgBrightRed", | ||
| "rawValue": true, | ||
| "backgroundColor": "bgYellow", | ||
| "color": "black", | ||
| "rawValue": true | ||
| }, | ||
| { | ||
| "id": "lbl-tokens-total", | ||
| "type": "custom-text", | ||
| "customText": "Tt", | ||
| "backgroundColor": "bgGreen", | ||
| "color": "black", | ||
| "bold": true, | ||
| "merge": "no-padding" | ||
| }, | ||
| { | ||
| "id": "9bacbdb4-2e01-45de-a0c0-ee6ec30fa3c2", | ||
| "type": "tokens-total", | ||
| "backgroundColor": "bgGreen", | ||
| "color": "black", | ||
| "rawValue": true |
There was a problem hiding this comment.
Please document this config-system change in .devcontainer/CLAUDE.md.
This PR changes statusline config behavior and conventions, but there’s no corresponding docs update in the provided changes. Please add/update guidance so future edits stay consistent.
Based on learnings: Config system changes MUST be reflected in .devcontainer/CLAUDE.md.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.devcontainer/config/defaults/ccstatusline-settings.json around lines 23 -
85, The PR changed statusline config behavior and conventions but no docs were
updated; add/update CLAUDE.md to document the new keys and conventions: describe
the new widget types ("tokens-input", "tokens-output", "tokens-cached",
"tokens-total", and "custom-text" label entries like
"lbl-tokens-input"/"lbl-tokens-output"/"lbl-tokens-cached"/"lbl-tokens-total"),
the new properties used ("rawValue", "merge": "no-padding", "backgroundColor"
and color conventions like bgBlue/bgMagenta/bgYellow/bgGreen and
brightWhite/black), and provide a minimal example snippet mirroring the diff
plus a short migration note explaining expected behavior changes and how to
add/update statusline entries.
- Add rawValue to model widget to strip "Model:" prefix - Replace merge: no-padding with normal spacing between token widgets - Give each token widget a distinct background (blue, magenta, yellow, green) - Add bold 2-char custom-text labels (In, Ou, Ca, Tt) fused to each token widget
Resolves CodeRabbit review: config-system changes require matching documentation. Adds Status Bar Widgets section covering widget properties, token color conventions, label fusion pattern, and available widget types. Adds changelog entry for the styling changes and documentation update.
c7c73ff to
c8e68e0
Compare
Summary
rawValue: truemerge: "no-padding"from the data widgetsIn,Ou,Ca,Tt) ascustom-textlabels fused to each token widget viamerge: "no-padding", so each token metric is immediately identifiable at a glanceTest plan
ccstatusline-settings.jsonto~/.config/ccstatusline/settings.jsonSummary by CodeRabbit
New Features
Style
Documentation