Move away from setting HOST in ctng-activation scripts#172
Open
timsnyder wants to merge 1 commit intoAnacondaRecipes:masterfrom
Open
Move away from setting HOST in ctng-activation scripts#172timsnyder wants to merge 1 commit intoAnacondaRecipes:masterfrom
timsnyder wants to merge 1 commit intoAnacondaRecipes:masterfrom
Conversation
Define new CONDA_TOOLCHAIN_HOST variable that is set the way HOST was previously set. HOST is now set only when CONDA_BUILD or CONDA_ACTIVATION_SET_HOST is set to 1 fixes AnacondaRecipes#151
Contributor
|
Nice compatibility design. @forrestwaters please merge this before you start further work on the compilers. |
Author
|
@msarahan and @forrestwaters, while in-between gigs during Q4 last year, I didn't pay attention to this but it seems like my PR has gotten stale. Would it be useful for me to push an update? Is this still something you'd like to merge? |
Contributor
|
Yes, we'd like to get this fixed for sure @timsnyder, if you want to push it to conda-forge we'll look to resync from there though, unless you really want to route it this way? |
Open
1 task
varlackc
reviewed
Jul 10, 2023
Contributor
varlackc
left a comment
varlackc
left a comment
There was a problem hiding this comment.
This PR has been open for a few years at this point, maybe we should close it at this point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define new CONDA_TOOLCHAIN_HOST variable that is set the
way HOST was previously set.
HOST is now set only when CONDA_BUILD or CONDA_ACTIVATION_SET_HOST
is set to 1
fixes #151