docs: add MAX_JOB_RETRIES, PROXY_URLS, DISABLE_HOSTED_HINTS to .env.example - #44
Open
MayurK-cmd wants to merge 5 commits into
Open
docs: add MAX_JOB_RETRIES, PROXY_URLS, DISABLE_HOSTED_HINTS to .env.example#44MayurK-cmd wants to merge 5 commits into
MayurK-cmd wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #43
Adds three environment variables to
.env.examplethat the server already readsbut that were missing from the sample config:
MAX_JOB_RETRIES— max retries per job (default3), in the JobProcessing block. Read in
server/internal/config/config.go:57.PROXY_URLS— comma-separated proxy pool for auto-selection (ThompsonSampling), added right below the existing single
PROXY_URLfallback.Read in
server/internal/config/config.go:61.DISABLE_HOSTED_HINTS— set to"true"/"1"to suppress hostedservice tips in error messages. Read in
server/internal/processor/processor.go:324. Already documented in theREADME.mdenv table; now also present in the sample file.No behavior change — these variables already existed and were honored by the
server. This only makes them discoverable for fresh setups that copy
.env.example.How to test
cp .env.example .envgrep -E "MAX_JOB_RETRIES|PROXY_URLS|DISABLE_HOSTED_HINTS" .env.example
cd server && TELEMETRY=off go run ./cmd/serverMAX_JOB_RETRIES=9in.env, restart, and confirm the valueis honored (the existing config test at
server/internal/config/config_test.go:112covers this path).Checklist
cd server && go test ./...) — no code changed, config-only.env.examplealigned withconfig.go,processor.go, andREADME.md