feat: allow 'anakin' handler in domain config handler chain editor - #45
Open
MayurK-cmd wants to merge 1 commit into
Open
feat: allow 'anakin' handler in domain config handler chain editor#45MayurK-cmd wants to merge 1 commit into
MayurK-cmd wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #46
Adds the
anakinhandler to the available options in the Domain Configshandler-chain editor in the web dashboard.
The server already registers an
anakinhandler (anakin.io API fallback)whenever
ANAKIN_API_KEYis set (server/cmd/server/main.go:83-84, handlername
"anakin"inserver/internal/handler/api.go:92), and a domain config'shandlerChainis passed through as the chain'sAllowedHandlersfilter. Theform previously hardcoded the available handlers to
['http', 'browser'], soanakincould not be selected from the UI.How to test
ANAKIN_API_KEYset so the anakin handler is enabled.+ anakinbutton now appears(in addition to
+ http/+ browser) and can be added and reordered.handlerChainincludinganakinand confirm it persists(
GET /v1/domain-configsreturns the chain as saved).Checklist
cd server && go test ./...) — no Go code changed