Fix/proxy scores sort mutation - #48
Open
MayurK-cmd wants to merge 1 commit into
Open
Conversation
MayurK-cmd
force-pushed
the
fix/proxy-scores-sort-mutation
branch
from
August 4, 2026 12:52
9fbfc82 to
536898f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #47
Fixes an impure render in
webapp/src/pages/ProxyScores.tsxwhere the per-hostproxy score array was sorted in-place (
data.scores[host].sort(...)) duringrender, mutating state derived from the API response. Under
<StrictMode>therender runs twice in dev, amplifying the side effect.
The sort is now applied to a copy of the array:
No behavior change — the displayed order is identical.
How to test
scores are populated.
best-first per host (unchanged ordering).
Checklist