ViWrap set_up_env bug fix and improve experience for ViWrap download#62
Open
biociao wants to merge 2 commits intoAnantharamanLab:mainfrom
Open
ViWrap set_up_env bug fix and improve experience for ViWrap download#62biociao wants to merge 2 commits intoAnantharamanLab:mainfrom
ViWrap set_up_env bug fix and improve experience for ViWrap download#62biociao wants to merge 2 commits intoAnantharamanLab:mainfrom
Conversation
… package already exists.
…v`, where `-y(--yes)` in `mamba env create` was invalid in mamba<=v1.5.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
-y(--yes)argument is valid inmamba=1.5.1and above. Currentmamba=1.3.0will cause error when executeViWrap set_up_envas it use-yin eachmamba env create ** -y >/dev/null 2>&1. Refer to scripts/master_set_up_env.py:line 40Database downloading is time-consuming and easily interrupted by many reasons. So to avoid re-downloading those already finished _db could easy our pain. I add condition judgements to avoid overwritten already exists db files. To those partially downloaded packages, one can remove the corresponding files and execute
ViWrap downloadagain.