Unify poison signal semantics across refs#3
Closed
AnathemaOfficial wants to merge 1 commit intomainfrom
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR reseals the
POISON_SIGNALrule across the reference surfaces.It aligns:
What changed
quantified_flow < 0in the Rust reference sketchquantified_flowPOISON_SIGNALmeans the same thing everywhereWhy
The audit found a drift between:
docs/SIGNAL_PROVIDER_SPEC.mdref/README.mdref/syf_gate_ref.rsref/syf_gate_ref.pyThe docs and Python sketch treated negative
quantified_flowas poisoned input, while the Rust sketch did not.Result
The reference surfaces now agree on the fail-closed rule for poisoned signals.