test(global): created extraction and generation tests, and created ci#10
Merged
Conversation
df1cd42 to
0470ba0
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces extraction and generation tests along with CI configuration while refactoring various repository and handler modules to update SQLAlchemy query usage and standardize handler constructor signatures. Key changes include:
- Refactoring database access from session.query(...).get() to session.get(...).
- Updating constructors for handlers and the Extractor to include a blockchains parameter.
- Adjusting block range chunk sizes and adding a new commit-check GitHub workflow.
Reviewed Changes
Copilot reviewed 42 out of 42 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| repository/debridge/repository.py | Updated SQLAlchemy query method usage. |
| repository/database.py | Changed import of declarative_base to use sqlalchemy.orm. |
| repository/cctp/repository.py | Updated SQLAlchemy query method usage. |
| repository/ccip/repository.py | Updated SQLAlchemy query method usage. |
| repository/base.py | Added a new get_all method for fetching records. |
| repository/across/repository.py | Updated SQLAlchemy query method usage. |
| generator/omnibridge/generator.py | Removed table clearance call and updated token mapping comments. |
| extractor/stargate/handler.py | Updated init signature to include blockchains parameter. |
| extractor/ronin/handler.py | Updated init signature to include blockchains parameter. |
| extractor/polygon/handler.py | Updated init signature to include blockchains parameter. |
| extractor/omnibridge/handler.py | Updated init signature to include blockchains parameter. |
| extractor/extractor.py | Modified constructor and block range chunk calculation; enhanced docstring. |
| extractor/debridge/handler.py | Updated init signature and delegated blockchain name conversion. |
| extractor/cctp/handler.py | Updated init signature and altered blockchain name logic. |
| extractor/ccip/handler.py | Updated init signature to include blockchains parameter. |
| extractor/base_handler.py | Changed constructor to accept blockchains and added mapping logic. |
| extractor/across/handler.py | Updated init signature and removed debug print. |
| config/rpcs_base_config.yaml | Updated RPC endpoints and added new gnosis and BSC RPC entries. |
| cli/cli.py | Updated instantiation of Extractor to pass blockchains parameter. |
| .github/workflows/commit-check.yml | Added a new workflow to enforce commit conventions and sign-offs. |
Comments suppressed due to low confidence (2)
extractor/extractor.py:174
- [nitpick] Consider revising the comment for clarity, e.g. 'validate blockchain mapping', to better convey its intent.
# validate and blockchain mapping
generator/omnibridge/generator.py:224
- Ensure that the removal of the empty_table call is intentional, as it might lead to residual data not being cleared and affect subsequent operations.
self.xdai_cross_chain_transactions.empty_table()
0470ba0 to
3088d36
Compare
Signed-off-by: André Augusto <andre.augusto@tecnico.ulisboa.pt>
3088d36 to
fc1b0bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.