Skip to content

Small bugfixes & features #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cspotcode wants to merge 4 commits into from
Closed

Small bugfixes & features #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e632814
[fix] `async_hooks.js` has been renamed in newer node versions
jbunton-atlassian Feb 23, 2018
3601f35
[update] export disable() function which stops tracing
jbunton-atlassian Feb 23, 2018
049638c
[update] added visual _____ between async contexts in long stack trace
jbunton-atlassian Feb 23, 2018
65673f0
fix failing tests by updating expected stacks to match node v11, the …
Oct 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 13 additions & 14 deletions test/expected/promise-child-stack.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,20 @@
Error: hello
at scopeThrow (/scripts/promise-child-stack.js:r:c)
at <anonymous>
at process._tickCallback (internal/process/next_tick.js:r:c)
at Function.Module.runMain (module.js:r:c)
at startup (bootstrap_node.js:r:c)
at bootstrap_node.js:r:c
at PromiseWrap.emitInitNative (internal/async_hooks.js:r:c)
at Function.Module.runMain (internal/modules/cjs/loader.js:r:c)
at startup (internal/bootstrap/node.js:r:c)
at bootstrapNodeJSCore (internal/bootstrap/node.js:r:c)
at Promise.then (<anonymous>)
at Object.<anonymous> (/scripts/promise-child-stack.js:r:c)
at PromiseWrap.emitInitNative (internal/async_hooks.js:r:c)
at ____________________:r:c
at Function.resolve (<anonymous>)
at Object.<anonymous> (/scripts/promise-child-stack.js:r:c)
at Module._compile (module.js:r:c)
at Object.Module._extensions..js (module.js:r:c)
at Module.load (module.js:r:c)
at tryModuleLoad (module.js:r:c)
at Function.Module._load (module.js:r:c)
at Function.Module.runMain (module.js:r:c)
at startup (bootstrap_node.js:r:c)
at bootstrap_node.js:r:c
at Module._compile (internal/modules/cjs/loader.js:r:c)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:r:c)
at Module.load (internal/modules/cjs/loader.js:r:c)
at tryModuleLoad (internal/modules/cjs/loader.js:r:c)
at Function.Module._load (internal/modules/cjs/loader.js:r:c)
at Function.Module.runMain (internal/modules/cjs/loader.js:r:c)
at startup (internal/bootstrap/node.js:r:c)
at bootstrapNodeJSCore (internal/bootstrap/node.js:r:c)
at ____________________:r:c
16 changes: 8 additions & 8 deletions test/expected/regression-delayed-formater.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@ throw new Error('trace');

Error: trace
at-hack Object.<anonymous> (/scripts/regression-delayed-formater.js:r:c)
at-hack Module._compile (module.js:r:c)
at-hack Object.Module._extensions..js (module.js:r:c)
at-hack Module.load (module.js:r:c)
at-hack tryModuleLoad (module.js:r:c)
at-hack Function.Module._load (module.js:r:c)
at-hack Function.Module.runMain (module.js:r:c)
at-hack startup (bootstrap_node.js:r:c)
at-hack bootstrap_node.js:r:c
at-hack Module._compile (internal/modules/cjs/loader.js:r:c)
at-hack Object.Module._extensions..js (internal/modules/cjs/loader.js:r:c)
at-hack Module.load (internal/modules/cjs/loader.js:r:c)
at-hack tryModuleLoad (internal/modules/cjs/loader.js:r:c)
at-hack Function.Module._load (internal/modules/cjs/loader.js:r:c)
at-hack Function.Module.runMain (internal/modules/cjs/loader.js:r:c)
at-hack startup (internal/bootstrap/node.js:r:c)
at-hack bootstrapNodeJSCore (internal/bootstrap/node.js:r:c)
82 changes: 14 additions & 68 deletions test/expected/regression-http-close.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,87 +7,33 @@ Error: trace
at Object.onceWrapper (events.js:r:c)
at Server.emit (events.js:r:c)
at emitCloseNT (net.js:r:c)
at process._tickCallback (internal/process/next_tick.js:r:c)
at emitInitNative (internal/async_hooks.js:r:c)
at emitInitScript (internal/async_hooks.js:r:c)
at process.internalTickCallback (internal/process/next_tick.js:r:c)
at new TickObject (internal/process/next_tick.js:r:c)
at internalNextTick (internal/process/next_tick.js:r:c)
at nextTick (internal/process/next_tick.js:r:c)
at Server._emitCloseIfDrained (net.js:r:c)
at Server.close (net.js:r:c)
at IncomingMessage.end (/scripts/regression-http-close.js:r:c)
at Object.onceWrapper (events.js:r:c)
at IncomingMessage.emit (events.js:r:c)
at endReadableNT (_stream_readable.js:r:c)
at process._tickCallback (internal/process/next_tick.js:r:c)
at emitInitNative (internal/async_hooks.js:r:c)
at emitInitScript (internal/async_hooks.js:r:c)
at new TickObject (internal/process/next_tick.js:r:c)
at process.nextTick (internal/process/next_tick.js:r:c)
at endReadable (_stream_readable.js:r:c)
at IncomingMessage.Readable.read (_stream_readable.js:r:c)
at flow (_stream_readable.js:r:c)
at resume_ (_stream_readable.js:r:c)
at process._tickCallback (internal/process/next_tick.js:r:c)
at emitInitNative (internal/async_hooks.js:r:c)
at emitInitScript (internal/async_hooks.js:r:c)
at new TickObject (internal/process/next_tick.js:r:c)
at process.nextTick (internal/process/next_tick.js:r:c)
at resume (_stream_readable.js:r:c)
at IncomingMessage.Readable.resume (_stream_readable.js:r:c)
at IncomingMessage.Readable.on (_stream_readable.js:r:c)
at ClientRequest.get (/scripts/regression-http-close.js:r:c)
at Object.onceWrapper (events.js:r:c)
at ClientRequest.emit (events.js:r:c)
at HTTPParser.parserOnIncomingClient (_http_client.js:r:c)
at HTTPParser.parserOnHeadersComplete (_http_common.js:r:c)
at Socket.socketOnData (_http_client.js:r:c)
at Socket.emit (events.js:r:c)
at addChunk (_stream_readable.js:r:c)
at readableAddChunk (_stream_readable.js:r:c)
at Socket.Readable.push (_stream_readable.js:r:c)
at TCP.onread (net.js:r:c)
at HTTPParser.emitInitNative (internal/async_hooks.js:r:c)
at tickOnSocket (_http_client.js:r:c)
at onSocketNT (_http_client.js:r:c)
at process._tickCallback (internal/process/next_tick.js:r:c)
at emitInitNative (internal/async_hooks.js:r:c)
at emitInitScript (internal/async_hooks.js:r:c)
at new TickObject (internal/process/next_tick.js:r:c)
at process.nextTick (internal/process/next_tick.js:r:c)
at ClientRequest.onSocket (_http_client.js:r:c)
at handleSocketCreation_Inner (_http_agent.js:r:c)
at oncreate (_http_agent.js:r:c)
at Agent.createSocket (_http_agent.js:r:c)
at Agent.addRequest (_http_agent.js:r:c)
at new ClientRequest (_http_client.js:r:c)
at request (http.js:r:c)
at Object.get (http.js:r:c)
at Server.listen (/scripts/regression-http-close.js:r:c)
at Object.onceWrapper (events.js:r:c)
at Server.emit (events.js:r:c)
at emitListeningNT (net.js:r:c)
at process._tickCallback (internal/process/next_tick.js:r:c)
at emitInitNative (internal/async_hooks.js:r:c)
at emitInitScript (internal/async_hooks.js:r:c)
at new TickObject (internal/process/next_tick.js:r:c)
at internalNextTick (internal/process/next_tick.js:r:c)
at Server.setupListenHandle [as _listen2] (net.js:r:c)
at TCP.emitInitNative (internal/async_hooks.js:r:c)
at process.internalTickCallback (internal/process/next_tick.js:r:c)
at ____________________:r:c
at createServerHandle (net.js:r:c)
at Server.setupListenHandle [as _listen2] (net.js:r:c)
at listenInCluster (net.js:r:c)
at GetAddrInfoReqWrap.doListen [as callback] (net.js:r:c)
at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:r:c)
at GetAddrInfoReqWrap.emitInitNative (internal/async_hooks.js:r:c)
at ____________________:r:c
at Object.lookup (dns.js:r:c)
at lookupAndListen (net.js:r:c)
at Server.listen (net.js:r:c)
at Object.<anonymous> (/scripts/regression-http-close.js:r:c)
at Module._compile (module.js:r:c)
at Object.Module._extensions..js (module.js:r:c)
at Module.load (module.js:r:c)
at tryModuleLoad (module.js:r:c)
at Function.Module._load (module.js:r:c)
at Function.Module.runMain (module.js:r:c)
at startup (bootstrap_node.js:r:c)
at bootstrap_node.js:r:c
at Module._compile (internal/modules/cjs/loader.js:r:c)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:r:c)
at Module.load (internal/modules/cjs/loader.js:r:c)
at tryModuleLoad (internal/modules/cjs/loader.js:r:c)
at Function.Module._load (internal/modules/cjs/loader.js:r:c)
at Function.Module.runMain (internal/modules/cjs/loader.js:r:c)
at startup (internal/bootstrap/node.js:r:c)
at bootstrapNodeJSCore (internal/bootstrap/node.js:r:c)
at ____________________:r:c
37 changes: 21 additions & 16 deletions test/expected/regression-http-parser.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,16 @@
Error: trace
at Socket.res.socket._read (/scripts/regression-http-parser.js:r:c)
at Socket.Readable.read (_stream_readable.js:r:c)
at maybeReadMore_ (_stream_readable.js:r:c)
at process.internalTickCallback (internal/process/next_tick.js:r:c)
at new TickObject (internal/process/next_tick.js:r:c)
at process.nextTick (internal/process/next_tick.js:r:c)
at maybeReadMore (_stream_readable.js:r:c)
at addChunk (_stream_readable.js:r:c)
at readableAddChunk (_stream_readable.js:r:c)
at Socket.Readable.push (_stream_readable.js:r:c)
at TCP.onread (net.js:r:c)
at TCP.emitInitNative (internal/async_hooks.js:r:c)
at TCP.onStreamRead [as onread] (internal/stream_base_commons.js:r:c)
at ____________________:r:c
at Socket.connect (net.js:r:c)
at Agent.connect [as createConnection] (net.js:r:c)
at Agent.createSocket (_http_agent.js:r:c)
Expand All @@ -21,28 +26,28 @@ Error: trace
at Object.onceWrapper (events.js:r:c)
at Server.emit (events.js:r:c)
at emitListeningNT (net.js:r:c)
at process._tickCallback (internal/process/next_tick.js:r:c)
at emitInitNative (internal/async_hooks.js:r:c)
at emitInitScript (internal/async_hooks.js:r:c)
at process.internalTickCallback (internal/process/next_tick.js:r:c)
at ____________________:r:c
at new TickObject (internal/process/next_tick.js:r:c)
at internalNextTick (internal/process/next_tick.js:r:c)
at nextTick (internal/process/next_tick.js:r:c)
at Server.setupListenHandle [as _listen2] (net.js:r:c)
at TCP.emitInitNative (internal/async_hooks.js:r:c)
at ____________________:r:c
at createServerHandle (net.js:r:c)
at Server.setupListenHandle [as _listen2] (net.js:r:c)
at listenInCluster (net.js:r:c)
at GetAddrInfoReqWrap.doListen [as callback] (net.js:r:c)
at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:r:c)
at GetAddrInfoReqWrap.emitInitNative (internal/async_hooks.js:r:c)
at ____________________:r:c
at Object.lookup (dns.js:r:c)
at lookupAndListen (net.js:r:c)
at Server.listen (net.js:r:c)
at Object.<anonymous> (/scripts/regression-http-parser.js:r:c)
at Module._compile (module.js:r:c)
at Object.Module._extensions..js (module.js:r:c)
at Module.load (module.js:r:c)
at tryModuleLoad (module.js:r:c)
at Function.Module._load (module.js:r:c)
at Function.Module.runMain (module.js:r:c)
at startup (bootstrap_node.js:r:c)
at bootstrap_node.js:r:c
at Module._compile (internal/modules/cjs/loader.js:r:c)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:r:c)
at Module.load (internal/modules/cjs/loader.js:r:c)
at tryModuleLoad (internal/modules/cjs/loader.js:r:c)
at Function.Module._load (internal/modules/cjs/loader.js:r:c)
at Function.Module.runMain (internal/modules/cjs/loader.js:r:c)
at startup (internal/bootstrap/node.js:r:c)
at bootstrapNodeJSCore (internal/bootstrap/node.js:r:c)
at ____________________:r:c
27 changes: 11 additions & 16 deletions test/expected/regression-net-connect.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,32 +3,27 @@
^

Error: connect ECONNREFUSED 127.0.0.1:24075
at Object._errnoException (util.js:r:c)
at _exceptionWithHostPort (util.js:r:c)
at TCPConnectWrap.afterConnect [as oncomplete] (net.js:r:c)
at emitInitNative (internal/async_hooks.js:r:c)
at emitInitScript (internal/async_hooks.js:r:c)
at new TickObject (internal/process/next_tick.js:r:c)
at process.nextTick (internal/process/next_tick.js:r:c)
at _destroy (internal/streams/destroy.js:r:c)
at Socket._destroy (net.js:r:c)
at Socket.destroy (internal/streams/destroy.js:r:c)
at TCPConnectWrap.afterConnect [as oncomplete] (net.js:r:c)
at TCPConnectWrap.emitInitNative (internal/async_hooks.js:r:c)
at net.js:r:c
at defaultTriggerAsyncIdScope (internal/async_hooks.js:r:c)
at ____________________:r:c
at internalConnect (net.js:r:c)
at GetAddrInfoReqWrap.emitLookup [as callback] (net.js:r:c)
at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:r:c)
at TCP.emitInitNative (internal/async_hooks.js:r:c)
at ____________________:r:c
at Socket.connect (net.js:r:c)
at Object.connect (net.js:r:c)
at Object.<anonymous> (/scripts/regression-net-connect.js:r:c)
at Module._compile (module.js:r:c)
at Object.Module._extensions..js (module.js:r:c)
at Module.load (module.js:r:c)
at tryModuleLoad (module.js:r:c)
at Function.Module._load (module.js:r:c)
at Function.Module.runMain (module.js:r:c)
at startup (bootstrap_node.js:r:c)
at bootstrap_node.js:r:c
at Module._compile (internal/modules/cjs/loader.js:r:c)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:r:c)
at Module.load (internal/modules/cjs/loader.js:r:c)
at tryModuleLoad (internal/modules/cjs/loader.js:r:c)
at Function.Module._load (internal/modules/cjs/loader.js:r:c)
at Function.Module.runMain (internal/modules/cjs/loader.js:r:c)
at startup (internal/bootstrap/node.js:r:c)
at bootstrapNodeJSCore (internal/bootstrap/node.js:r:c)
at ____________________:r:c
20 changes: 10 additions & 10 deletions test/expected/regression-net-socket.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,22 +6,22 @@ Error: trace
at Server.<anonymous> (/scripts/regression-net-socket.js:r:c)
at Server.emit (events.js:r:c)
at TCP.onconnection (net.js:r:c)
at TCP.emitInitNative (internal/async_hooks.js:r:c)
at createServerHandle (net.js:r:c)
at Server.setupListenHandle [as _listen2] (net.js:r:c)
at listenInCluster (net.js:r:c)
at GetAddrInfoReqWrap.doListen [as callback] (net.js:r:c)
at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:r:c)
at GetAddrInfoReqWrap.emitInitNative (internal/async_hooks.js:r:c)
at ____________________:r:c
at Object.lookup (dns.js:r:c)
at lookupAndListen (net.js:r:c)
at Server.listen (net.js:r:c)
at Object.<anonymous> (/scripts/regression-net-socket.js:r:c)
at Module._compile (module.js:r:c)
at Object.Module._extensions..js (module.js:r:c)
at Module.load (module.js:r:c)
at tryModuleLoad (module.js:r:c)
at Function.Module._load (module.js:r:c)
at Function.Module.runMain (module.js:r:c)
at startup (bootstrap_node.js:r:c)
at bootstrap_node.js:r:c
at Module._compile (internal/modules/cjs/loader.js:r:c)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:r:c)
at Module.load (internal/modules/cjs/loader.js:r:c)
at tryModuleLoad (internal/modules/cjs/loader.js:r:c)
at Function.Module._load (internal/modules/cjs/loader.js:r:c)
at Function.Module.runMain (internal/modules/cjs/loader.js:r:c)
at startup (internal/bootstrap/node.js:r:c)
at bootstrapNodeJSCore (internal/bootstrap/node.js:r:c)
at ____________________:r:c
38 changes: 19 additions & 19 deletions test/expected/simple-fs-read.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,23 +4,23 @@

Error: trace
at callback (/scripts/simple-fs-read.js:r:c)
at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:r:c)
at FSReqWrap.emitInitNative (internal/async_hooks.js:r:c)
at ReadFileContext.close (fs.js:r:c)
at FSReqWrap.readFileAfterRead [as oncomplete] (fs.js:r:c)
at FSReqWrap.emitInitNative (internal/async_hooks.js:r:c)
at ReadFileContext.read (fs.js:r:c)
at FSReqWrap.readFileAfterStat [as oncomplete] (fs.js:r:c)
at FSReqWrap.emitInitNative (internal/async_hooks.js:r:c)
at FSReqWrap.readFileAfterOpen [as oncomplete] (fs.js:r:c)
at FSReqWrap.emitInitNative (internal/async_hooks.js:r:c)
at Object.fs.readFile (fs.js:r:c)
at FSReqCallback.readFileAfterClose [as oncomplete] (internal/fs/read_file_context.js:r:c)
at ReadFileContext.close (internal/fs/read_file_context.js:r:c)
at FSReqCallback.readFileAfterRead [as oncomplete] (internal/fs/read_file_context.js:r:c)
at ____________________:r:c
at ReadFileContext.read (internal/fs/read_file_context.js:r:c)
at FSReqCallback.readFileAfterStat [as oncomplete] (fs.js:r:c)
at ____________________:r:c
at FSReqCallback.readFileAfterOpen [as oncomplete] (fs.js:r:c)
at ____________________:r:c
at Object.readFile (fs.js:r:c)
at Object.<anonymous> (/scripts/simple-fs-read.js:r:c)
at Module._compile (module.js:r:c)
at Object.Module._extensions..js (module.js:r:c)
at Module.load (module.js:r:c)
at tryModuleLoad (module.js:r:c)
at Function.Module._load (module.js:r:c)
at Function.Module.runMain (module.js:r:c)
at startup (bootstrap_node.js:r:c)
at bootstrap_node.js:r:c
at Module._compile (internal/modules/cjs/loader.js:r:c)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:r:c)
at Module.load (internal/modules/cjs/loader.js:r:c)
at tryModuleLoad (internal/modules/cjs/loader.js:r:c)
at Function.Module._load (internal/modules/cjs/loader.js:r:c)
at Function.Module.runMain (internal/modules/cjs/loader.js:r:c)
at startup (internal/bootstrap/node.js:r:c)
at bootstrapNodeJSCore (internal/bootstrap/node.js:r:c)
at ____________________:r:c
26 changes: 13 additions & 13 deletions test/expected/simple-next-tick.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,20 @@

Error: trace
at callback (/scripts/simple-next-tick.js:r:c)
at internalTickCallback (internal/process/next_tick.js:r:c)
at process._tickCallback (internal/process/next_tick.js:r:c)
at Function.Module.runMain (module.js:r:c)
at startup (bootstrap_node.js:r:c)
at bootstrap_node.js:r:c
at emitInitNative (internal/async_hooks.js:r:c)
at emitInitScript (internal/async_hooks.js:r:c)
at Function.Module.runMain (internal/modules/cjs/loader.js:r:c)
at startup (internal/bootstrap/node.js:r:c)
at bootstrapNodeJSCore (internal/bootstrap/node.js:r:c)
at new TickObject (internal/process/next_tick.js:r:c)
at process.nextTick (internal/process/next_tick.js:r:c)
at Object.<anonymous> (/scripts/simple-next-tick.js:r:c)
at Module._compile (module.js:r:c)
at Object.Module._extensions..js (module.js:r:c)
at Module.load (module.js:r:c)
at tryModuleLoad (module.js:r:c)
at Function.Module._load (module.js:r:c)
at Function.Module.runMain (module.js:r:c)
at startup (bootstrap_node.js:r:c)
at bootstrap_node.js:r:c
at Module._compile (internal/modules/cjs/loader.js:r:c)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:r:c)
at Module.load (internal/modules/cjs/loader.js:r:c)
at tryModuleLoad (internal/modules/cjs/loader.js:r:c)
at Function.Module._load (internal/modules/cjs/loader.js:r:c)
at Function.Module.runMain (internal/modules/cjs/loader.js:r:c)
at startup (internal/bootstrap/node.js:r:c)
at bootstrapNodeJSCore (internal/bootstrap/node.js:r:c)
at ____________________:r:c
Loading