[test] Ignore stack lines from outside our test code#51
Closed
cspotcode wants to merge 2 commits intoAndreasMadsen:masterfrom
Closed
[test] Ignore stack lines from outside our test code#51cspotcode wants to merge 2 commits intoAndreasMadsen:masterfrom
cspotcode wants to merge 2 commits intoAndreasMadsen:masterfrom
Conversation
This stops the tests from breaking with Node.js updates.
Owner
|
This makes the test too relaxed. It was this way a long time ago, but there are some bugs related to removing lines that this won't test for. |
Contributor
Author
|
Ok, would you like a PR that fixes failing tests by updating them for node v11, the version being used by the TravisCI tests? |
Owner
|
Sure, we can do that. I don't care that much about a green TravisCI myself. I just use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splitting #40 into multiple PRs for easier review.
This stops the tests from breaking with Node.js updates.