Fix copyElementImageToTexture calls in current Chromium - #7
Open
postmelee wants to merge 1 commit into
Open
Conversation
|
@postmelee is attempting to deploy a commit to the Andrew Peter Prifer's projects Team on Vercel. A member of the Team first needs to authorize it. |
postmelee
marked this pull request as ready for review
July 16, 2026 16:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GPUQueue.copyElementImageToTextureextension to use Chromium's dictionary-based source and destination argumentsRoot cause
DomContentSyncstill used the earlier four-argument form:Current Chromium interprets the first argument as a
GPUCopyElementImageSourcedictionary. Passing the element directly therefore throws:The renderer continued drawing the WebGPU glass geometry, but DOM-backed backgrounds, icons, and text were left black. The updated call matches the Chrome 150 implementation:
Impact
DOM content renders again when Liquid DOM runs in current Chromium with WebGPU and
chrome://flags/#canvas-draw-elementenabled.Validation
pnpm --filter @liquid-dom/core test— 6 files and 32 tests passedpnpm --filter @liquid-dom/core buildpnpm release:check150.0.7871.115