chore: remove dead eslint-disable comments from example files#179
chore: remove dead eslint-disable comments from example files#179gabrypavanello wants to merge 1 commit intomainfrom
Conversation
The weather-app example project has no lint target in NX, so the inline `eslint-disable-line no-console` comments in handlers and middleware were never evaluated and served no purpose. Console output is intentional in example code anyway. Removes 3 unnecessary suppression comments.
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughSummary by CodeRabbit
WalkthroughESLint disable comments are removed from console.log statements in two files within the weather-app example. The actual logging functionality remains unchanged; only inline linting suppressions are eliminated. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Comment |
Code ReviewSummary: Removing 3 dead Correctness of the claimThe reasoning holds up. The root Code qualityThe change is clean and focused. Removing misleading suppressions improves the signal-to-noise ratio in reference code that developers read to learn patterns. One suggestion worth consideringSince A small proactive addition to // Examples — console output is intentional in demo code
{
files: ["examples/**/*.ts", "examples/**/*.tsx"],
rules: {
"no-console": "off",
},
},This is not a blocker — the PR description already calls this out as the right approach — but landing it alongside the cleanup would close the loop completely. RiskNone. Comment-only change; no logic affected. VerdictApproved as-is. The optional ESLint override above is worth a follow-up if the team ever adds linting to examples. |
Kaizen — Monday Feb 23 2026
What: Removed 3
// eslint-disable-line no-consolecomments fromexamples/weather-app/handler and middleware files.Why: The weather-app example project has no
linttarget in NX — these suppressions were never evaluated by any lint run. They were dead code adding noise to files developers use as reference.Console output is intentional in demo/example code. Even if lint were added in future, an eslint config-level override would be the right approach — not per-line suppressions.
Risk: None — comment-only change, no logic affected.
Verified: Build ✅ | Tests ✅ (1669 passed)