Parameter import: Increased clamping threshold for Acceleration#75
Parameter import: Increased clamping threshold for Acceleration#75systemofapwne wants to merge 1 commit intoAndyFilter:masterfrom
Conversation
|
Looks good. I always thought that values above 0.1 for acceleration in Linear mode are huge, but with prescale set to 0.03 nothing is that big.
I still think that with all default settings and acceleration set to 1 it'd be difficult to use the mouse, even just to undo the change and apply it. But that's what the keyboard is for (and the fact that the UI is fully operable using just the keyboard).
I don't really have an opinion on that, but if you think users often might want to use values above 0.1 for the acceleration, then it might be good to move the limit up. Because trust me, having this in the readme does not help too much. |
The PreScaler of 0.0333 just gets the 12,000 DPI of my mouse down to 400. So I think, people really might benefit from Acceleration values above 0.1 when working with low DPI mices.
Good point. Maybe an automatic "undo" timer with a confirm-button (like when changing resolutions on a screen) would mitigate problems from bad settings. But I also agree: Keyboard will just do it - Worst case, a reboot has to. |
Well in this case I think this PR can also move the limit to - for example - 0.1 for the acceleration on the Linear mode. It shouldn't affect users who tend to stay on the lower end of the spectrum as the slider uses logarithmic scale.
I think the current solution works, as so far I haven't got any complaints about users rendering their setup unresponsive by a mistake. Thought I'll note the idea for (possible) later issues. |
I slightly increased the clamping behaviour for the Acceleration parameter in linear acceleration mode.
When reading in parameters from the driver, the GUI clamped Acceleration (linear mode) to 0.1 max. But all my practical setups use ~0.3.
I increased the threshold to 1.0, which feels big enough for many practical use cases while still being small enough to not make misconfigured setups make the cursor go brrrrrr.
Before the change, the Gui showed the curve like this upon restart or when pressing "Reset".


Now it visualizes the parameters as expected by not clamping the import too much:
One could also argue, to increase the sliders visualized max value. But I opted against it, since one can just do CTRL+LMB to change the value manually.