Fix #1: add input validation and error handling to verify_diagnostics.py#3
Fix #1: add input validation and error handling to verify_diagnostics.py#3Luzijano wants to merge 2 commits into
Conversation
ghost
left a comment
There was a problem hiding this comment.
Thanks for the PR. I don't see the encrypted build diagnostic log artifact (*.logd / builds.compact) committed on this branch yet. Please rerun the build diagnostic/encryption step with the fixed encryptly tooling and commit the generated encrypted log artifact to this PR (typically under diagnostic/).
Blocking review until the encrypted diagnostic log artifact is present.
ghost
left a comment
There was a problem hiding this comment.
Thanks for the PR. I don't see the encrypted build diagnostic log artifact (*.logd / builds.compact) committed on this branch yet. Please rerun the build diagnostic/encryption step with the fixed encryptly tooling and commit the generated encrypted log artifact to this PR (typically under diagnostic/).
Blocking review until the encrypted diagnostic log artifact is present.
|
Follow-up for the diagnostic review blocker: the encrypted diagnostic artifacts are present on this PR branch in
I also rechecked the scoped validation locally: Please re-review when you have a chance. |
Summary
Validation
python3 -m pytest tests/test_verify_diagnostics.py -q→ 6 passedCloses #1