fix: preserve trace SVG byte contract on Windows - #20
Merged
Conversation
Anionex
force-pushed
the
codex/windows-trace-byte-contract
branch
from
August 14, 2026 05:20
79cadb4 to
8ccf9d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows,
Path.write_text()translates each SVG\nto\r\n, whiletracereportslen(svg). Multi-line output therefore reports fewer bytes than were written, and strict consumers reject the artifact.len(svg)is also a character count rather than a UTF-8 byte count.Downstream context: Anionex/dsh-vision-toolkit#8.
Fix
Path.write_bytes()Verification
python3 -m py_compile vision_proxy.py vision_client.py ground.py detect.py bin/glance bin/trace bin/croppython3 tests/test_trace.py— focused unit regression passeduv run --with pillow --with vtracer python tests/test_trace.py— full trace CLI path passedgit diff --checkThis is a non-UI CLI contract fix; there is no browser path. The byte-for-byte assertion and Windows CI execution cover the affected behavior.