Skip to content

fix: make Windows bundle installs portable - #14

Merged
Anionex merged 1 commit into
mainfrom
codex/issues-5-6
Aug 14, 2026
Merged

fix: make Windows bundle installs portable#14
Anionex merged 1 commit into
mainfrom
codex/issues-5-6

Conversation

@Anionex

@Anionex Anionex commented Aug 14, 2026

Copy link
Copy Markdown
Owner

Background

Windows profile installs had two independent portability failures:

  • the built ESM entry imported the unscoped schemastery package, while DSH exposes its shared schema runtime as @deepseek-ai/schemastery through the profile module fallback;
  • core.autocrlf=true converted the vendored upstream snapshot to CRLF during checkout, so the intentional SHA-256/byte-count integrity check rejected every converted text file.

Changes

  • import and declare the host-provided @deepseek-ai/schemastery peer instead of relying on an uninstalled unscoped package;
  • keep the DSH client metadata and pushed Settings/Credential invalidations aligned with the current Remote API so the package builds against the supported harness;
  • mark vendor/agent-vision-toolkit/** as byte-preserved Git content without weakening runtime integrity validation;
  • make the portable gate perform a real temporary core.autocrlf=true clone and rerun UPSTREAM_MANIFEST.json verification;
  • make the profile E2E install the generated tarball into a clean DSH_HOME, assert no unscoped schemastery workaround exists, boot the real profile, exercise the tools, and uninstall;
  • update the E2E/test harness for the current DSH CLI and Subprocess service names.

This intentionally does not add the documentation-only junction or checkout workarounds proposed in #10.

Verification

  • @deepseek-ai/dsh@0.1.0-rc.6 clean tarball/profile E2E: 1/1 passed
  • complete Vitest suite against the matching DSH source layout with the rc.6 CLI: 17 files, 136 tests passed
  • npm run build: passed
  • npm run verify:portable: passed, including the actual core.autocrlf=true checkout regression
  • pnpm run example:ui-restoration: passed (6.04% initial difference to 0% final)
  • pnpm pack --dry-run: passed
  • git diff --check: passed

No browser walkthrough applies: this PR changes package/module resolution, checkout byte stability, and install/build compatibility. The substitute acceptance path is the real clean-profile tarball install, boot, tool execution, disable/re-enable, and uninstall E2E.

Closes #5
Closes #6

@Anionex
Anionex merged commit f78971e into main Aug 14, 2026
2 checks passed
@Anionex
Anionex deleted the codex/issues-5-6 branch August 14, 2026 05:51
Anionex pushed a commit to knlght/dsh-vision-toolkit that referenced this pull request Aug 14, 2026
Update the public README, landing page, support, issue-template, changelog, and package metadata links to the live Anionex repository. Keep the npm package scope unchanged and extend the portable gate so retired repository URLs cannot return on public surfaces.

Drop the Windows checkout and dependency workarounds from the original proposal because PR Anionex#14 fixed both in the package. The existing Python override documentation already covers interpreter discovery after PR Anionex#4 made bootstrap resolution explicit.

Co-Authored-By: DeepSeek Harness <noreply@deepseek.com>
Anionex pushed a commit to knlght/dsh-vision-toolkit that referenced this pull request Aug 14, 2026
Update the public README, landing page, support, issue-template, changelog, and package metadata links to the live Anionex repository. Keep the npm package scope unchanged and extend the portable gate so retired repository URLs cannot return on public surfaces.

Drop the Windows checkout and dependency workarounds from the original proposal because PR Anionex#14 fixed both in the package. The existing Python override documentation already covers interpreter discovery after PR Anionex#4 made bootstrap resolution explicit.

Co-Authored-By: DeepSeek Harness <noreply@deepseek.com>
Anionex pushed a commit that referenced this pull request Aug 14, 2026
Update the public README, landing page, support, issue-template, changelog, and package metadata links to the live Anionex repository. Keep the npm package scope unchanged and extend the portable gate so retired repository URLs cannot return on public surfaces.

Drop the Windows checkout and dependency workarounds from the original proposal because PR #14 fixed both in the package. The existing Python override documentation already covers interpreter discovery after PR #4 made bootstrap resolution explicit.

Co-authored-by: DeepSeek Harness <noreply@deepseek.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant