Improve dark mode consistency, accessibility, and visual hierarchy#58
Open
Keerthan-Bhat wants to merge 2 commits into
Open
Improve dark mode consistency, accessibility, and visual hierarchy#58Keerthan-Bhat wants to merge 2 commits into
Keerthan-Bhat wants to merge 2 commits into
Conversation
Owner
|
@Keerthan-Bhat whaat things you changed mark in sshot |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Description
Overview This PR improves the core dark mode experience of the application by introducing a more cohesive color palette, improving text-to-background contrast, and establishing a clearer elevation hierarchy across components.
Changes Made
Theme Variables (index.css):

Refined --color-background to a deeper dark tone (#090B10) to reduce glare and improve contrast.
Updated surface variables (--color-surface, --color-surface-elevated) for better visual depth.
Softened --color-text-primary to #F8FAFC to reduce eye strain while maintaining accessibility.
Introduced a new semantic variable --color-border-subtle (rgba(255, 255, 255, 0.06)) to replace hardcoded border opacities.
Component Refactoring:
BookPreviewCard.jsx: Replaced hardcoded utility classes (border-white/10, text-white) with the new semantic theme variables (border-border-subtle, text-text-primary) for consistent styling and easier future theming.
ActivityFeed.jsx: Replaced hardcoded utility classes (border-white/5, text-white) with semantic variables, ensuring a unified look across the dashboard.
Impact These changes give the application a more premium and polished feel, make the codebase easier to maintain by utilizing centralized CSS variables, and significantly improve reading comfort for users in dark environments.