checking the affect of removing @emotion/react#1
Open
gavriguy wants to merge 1 commit intoAnishpras:material-ui-examplefrom
Open
checking the affect of removing @emotion/react#1gavriguy wants to merge 1 commit intoAnishpras:material-ui-examplefrom
gavriguy wants to merge 1 commit intoAnishpras:material-ui-examplefrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi this PR is more a question than a suggestion.
I there is some code duplication between
entry.server.tsx&entry.client.tsx, I was thinking that maybe a good solution would be to move everything toroot.tsx.After I read you code I realized that you implemented it the way you did you wanted to use the
@emotion/cacheas described here https://mui.com/guides/server-rendering/I wanted to test the affect of removing
@emotion/cachealtogether to release that it works without it and all the MUI styles are injected in the HTML.Is that a Remix optimization? if so maybe you can drop the use of
@emotion/cache