feat: centralized secrets management (#289)#455
Open
ladinoraa wants to merge 1 commit into
Open
Conversation
…oe#289) Closes AnnabelJoe#289 - Documents all required secrets per environment (local / CI / production) - Explains gitignored .env.local for local dev - Lists all GitHub Actions secrets needed for CI and staging - Documents Vercel env vars for production - Covers production AWS Secrets Manager usage (no plaintext keys) - Documents key rotation procedure - References gitleaks / pre-commit secret scanning
|
@ladinoraa Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #289
Establishes a consistent, centralized approach to secrets management across all environments.
Changes
apps/web/.env.example— expanded with all required variable names, inline docs, per-environment guidance in the header.github/workflows/ci.yml— replaced hardcoded placeholder values with proper${{ secrets.* }}referencesdocs/ONBOARDING.md— added callout box clarifying local-dev / CI / production secret boundariesdocs/SECRETS.md(new) — canonical reference: required secrets table, per-environment setup, Vercel production config, key rotation procedure, secret scanning notesAcceptance criteria